Various infobars have no icon |
|||||
Issue descriptionthe text is: "Access to local files on your machine is disabled by your administrator." This infobar has never had an icon in ~4 years of existence. Should we reuse ic_business? https://chrome-assets.googleplex.com/?search=business.icon&path=src/ui/gfx/vector_icons&platform=5&grouped=true&flagged=false&shared=1
,
Feb 25 2017
bettes@ is the right owner. (my gut reaction: using the little building icon sounds reasonable) For BAD_FLAGS and PASSKIT, I wonder if the generic warning would work? Though it might be a bit too aggressive for PASSKIT ... https://chrome-assets.googleplex.com/?search=warning.svg&path=src/ui/webui/resources/images&platform=0&grouped=true&flagged=false&shared=1 WDYT, bettes@?
,
Feb 25 2017
,
Mar 6 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2018
Here are some infobars with no icon today: Dev tools Extension dev tools Incognito connectability NaCl File access disabled [the original bug here] Installation error Bad flags API keys Obsolete system Data reduction proxy preview Automation There may be others; I didn't test anything that can't be instantiated on Windows. To find out what each of these icons is, you can show them by invoking: browser_tests --gtest_filter=BrowserUiTest.Invoke --test-launcher-interactive --ui=InfoBarUiTest.InvokeUi_dev_tools (substitute your appropriate infobar name in for "dev_tools" above) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pkasting@chromium.org
, Feb 24 2017