Add haptic for success on adding to reading list |
|||||||
Issue descriptionThe HIG suggests "In general, provide haptic feedback in response to user-initiated actions." We should use the "success" haptic to accompany the "added to reading list" infobar.
,
Feb 24 2017
Manual tests required. Please test the above 4 states manually.
,
Feb 24 2017
https://codereview.chromium.org/2719513003 is a first cut. I can't install on my device anymore, so this will have to wait a few days.
,
Feb 27 2017
The actual 4 haptics are: - OS sharing success - print failures - password filling from 3rd party (ie, 1Password). - adding to reading list.
,
Feb 27 2017
,
Mar 2 2017
Fixed.
,
Mar 2 2017
once again, with feeling.
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07e27841f0a5a7c76d0192dd0a509a0c22aa5763 commit 07e27841f0a5a7c76d0192dd0a509a0c22aa5763 Author: pinkerton <pinkerton@chromium.org> Date: Thu Mar 02 15:29:02 2017 Adding success/failure notification haptics for HUD display. When we show a HUD bar for certain features, accompany it with a haptic indicating success or failure. This adds haptics for: - OS sharing success - print failures - password filling from 3rd party (ie, 1Password). - adding to reading list. BUG= 695914 TEST=Manual test only. See https://bugs.chromium.org/p/chromium/issues/detail?id=695914#c4 for manual test steps. Review-Url: https://codereview.chromium.org/2719513003 Cr-Commit-Position: refs/heads/master@{#454265} [modify] https://crrev.com/07e27841f0a5a7c76d0192dd0a509a0c22aa5763/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/07e27841f0a5a7c76d0192dd0a509a0c22aa5763/ios/chrome/browser/ui/uikit_ui_util.h [modify] https://crrev.com/07e27841f0a5a7c76d0192dd0a509a0c22aa5763/ios/chrome/browser/ui/uikit_ui_util.mm
,
Mar 7 2017
Tested in 59.0.3033.0 Canary, iPhone 7 iOS 10.2.1 Tested: 1. Print failures(Jam paper/printer is offline - no haptic action) FAIL 2. OS sharing success/fail (with Twitter, facebook, google plus) PASS 3. Password filling from 3rd party (ie, 1Password) PASS 4. Adding to reading list PASS
,
Mar 7 2017
@pinkerton, Please let me know if Print failures(Jam paper/printer is offline - no haptic action)is a valid haptic bug, and if so would like me to file a separate bug for that?
,
Mar 8 2017
That's one i couldn't test myself. Do you get a snakbar for the error? Please file a separate bug with steps and assign it to me. I'll take a look.
,
Mar 8 2017
There are no snakbar messages for Jam paper/printer offline errors. (Bug filed for Print failures 699704) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pinkerton@chromium.org
, Feb 24 2017