New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695914 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 649342



Sign in to add a comment

Add haptic for success on adding to reading list

Project Member Reported by pinkerton@chromium.org, Feb 24 2017

Issue description

The HIG suggests "In general, provide haptic feedback in response to user-initiated actions." We should use the "success" haptic to accompany the "added to reading list" infobar.
 
This is also adding success/failure haptics for the following HUDs:

- share success
- print failure
- password/autofill complete
- added to reading list.

Manual tests required. Please test the above 4 states manually. 
Status: Started (was: Assigned)
https://codereview.chromium.org/2719513003 is a first cut. I can't install on my device anymore, so this will have to wait a few days.
The actual 4 haptics are:

- OS sharing success
- print failures
- password filling from 3rd party (ie, 1Password). 
- adding to reading list.

Blocking: 649342
Fixed.
Status: Fixed (was: Started)
once again, with feeling.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07e27841f0a5a7c76d0192dd0a509a0c22aa5763

commit 07e27841f0a5a7c76d0192dd0a509a0c22aa5763
Author: pinkerton <pinkerton@chromium.org>
Date: Thu Mar 02 15:29:02 2017

Adding success/failure notification haptics for HUD display.

When we show a HUD bar for certain features, accompany it with a haptic
indicating success or failure. This adds haptics for:
- OS sharing success
- print failures
- password filling from 3rd party (ie, 1Password).
- adding to reading list.

BUG= 695914 
TEST=Manual test only. See
 https://bugs.chromium.org/p/chromium/issues/detail?id=695914#c4 for
manual test steps.

Review-Url: https://codereview.chromium.org/2719513003
Cr-Commit-Position: refs/heads/master@{#454265}

[modify] https://crrev.com/07e27841f0a5a7c76d0192dd0a509a0c22aa5763/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/07e27841f0a5a7c76d0192dd0a509a0c22aa5763/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/07e27841f0a5a7c76d0192dd0a509a0c22aa5763/ios/chrome/browser/ui/uikit_ui_util.mm

Status: Assigned (was: Fixed)
Tested in 59.0.3033.0 Canary, iPhone 7 iOS 10.2.1

Tested:
1. Print failures(Jam paper/printer is offline - no haptic action) FAIL
2. OS sharing success/fail (with Twitter, facebook, google plus) PASS
3. Password filling from 3rd party (ie, 1Password) PASS
4. Adding to reading list PASS
@pinkerton, Please let me know if Print failures(Jam paper/printer is offline - no haptic action)is a valid haptic bug, and if so would like me to file a separate bug for that?
Status: Fixed (was: Assigned)
That's one i couldn't test myself. Do you get a snakbar for the error? Please file a separate bug with steps and assign it to me. I'll take a look. 
Status: Verified (was: Fixed)
There are no snakbar messages for Jam paper/printer offline errors. 
(Bug filed for Print failures 699704)

Sign in to add a comment