New issue
Advanced search Search tips

Issue 695909 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

AV sync issue in WebRTC in 20% of streams

Project Member Reported by emir...@chromium.org, Feb 24 2017

Issue description

This bug is Chromium bug corresponding to WebRTC bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=7045

We request to merge the corresponding fix to M57. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 25 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by gov...@chromium.org, Feb 26 2017

Please merge your change to M57 branch 2987 by 5:00 PM PT Monday (02/27) so we can take it in for next week last M57 Desktop Beta release before Stable promotion. Thank you.

Comment 3 by n...@fb.com, Feb 27 2017

Labels: DevRel-Facebook
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecd17b7797c37dc21837cd7ee268f3e9474e3107

commit ecd17b7797c37dc21837cd7ee268f3e9474e3107
Author: emircan <emircan@chromium.org>
Date: Mon Feb 27 21:50:07 2017

Set capture_time_ms using rtc::TimeMicros()

capture_time_ms should be based on system clock and setting it by using camera capture
timestamp may cause sync issue, i.e. the bug below. Set this field using rtc::TimeMicros().

BUG= 695909 , webrtc:7045 

Review-Url: https://codereview.chromium.org/2692853009
Cr-Commit-Position: refs/heads/master@{#451171}
(cherry picked from commit 1dd4ccf354c3286647e35ed6e02c36de695901fc)
NOTRY=true
NOPRESUBMIT=true
TBR=mcasas@chromium.org,nisse@chromium.org,holmer@chromium.org

Review-Url: https://codereview.chromium.org/2716153005
Cr-Commit-Position: refs/branch-heads/2987@{#703}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/ecd17b7797c37dc21837cd7ee268f3e9474e3107/content/renderer/media/gpu/rtc_video_encoder.cc

Status: Fixed (was: Started)

Sign in to add a comment