HTMLOptionsCollection#getter namedItem should be inherited from HTMLCollection |
|||||||||
Issue descriptionIn addition, the other getter Node, shouldn't it be named item instead? Anyways, as commented in the IDL file: Neither of these getters are in the spec, and the getters inherited from HTMLCollection always return an Element.
,
Mar 9 2017
,
Aug 4 2017
> [ImplementedAs=namedGetter] getter (NodeList or Element)? namedItem(DOMString name); It should return just Element?. We have FIXME in the implementation of HTMLOptionsCollection::namedGetter, and http://w3c-test.org/html/infrastructure/common-dom-interfaces/collections/htmloptionscollection.html is failing due to this.
,
Aug 7 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9066877c61a7b81bdebaac0a658d25eedf72b8f commit d9066877c61a7b81bdebaac0a658d25eedf72b8f Author: Kent Tamura <tkent@chromium.org> Date: Tue Aug 08 00:59:19 2017 Update comments on getters of HTMLOptionsCollection and RadioNodeList. NOTRY=true Bug: 695902 , 752877 Change-Id: Idae08fba383baefdf8eb57e673c2f2a71138311d Reviewed-on: https://chromium-review.googlesource.com/604811 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#492480} [modify] https://crrev.com/d9066877c61a7b81bdebaac0a658d25eedf72b8f/third_party/WebKit/Source/core/html/HTMLOptionsCollection.idl [modify] https://crrev.com/d9066877c61a7b81bdebaac0a658d25eedf72b8f/third_party/WebKit/Source/core/html/RadioNodeList.idl
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a07404eb05fd1ba547e20daeff759f709f5e123e commit a07404eb05fd1ba547e20daeff759f709f5e123e Author: Kent Tamura <tkent@chromium.org> Date: Tue Aug 08 06:50:51 2017 Fix the return type of HTMLOptionsCollection's indexed property getter. Change 'Node' to 'Element?' in order to match to HTMLCollection's getter. This CL doesn't change any web-exposed behavior. Bug: 695902 Change-Id: Icfb8ca590eff1b581365350f6544f686be94bda2 Reviewed-on: https://chromium-review.googlesource.com/604813 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#492557} [modify] https://crrev.com/a07404eb05fd1ba547e20daeff759f709f5e123e/third_party/WebKit/Source/core/html/HTMLOptionsCollection.idl
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0d3d1ae7b3ae2957c328b90bee185adbe0ecd30 commit e0d3d1ae7b3ae2957c328b90bee185adbe0ecd30 Author: Kent Tamura <tkent@chromium.org> Date: Wed Aug 09 05:02:22 2017 Add a counter for a quirky behavior of HTMLOptionsCollection. Bug: 695902 Change-Id: Id2ff69a54d13abd415e5a05564520e213384d61b Reviewed-on: https://chromium-review.googlesource.com/606565 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#492828} [modify] https://crrev.com/e0d3d1ae7b3ae2957c328b90bee185adbe0ecd30/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp [modify] https://crrev.com/e0d3d1ae7b3ae2957c328b90bee185adbe0ecd30/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/e0d3d1ae7b3ae2957c328b90bee185adbe0ecd30/tools/metrics/histograms/enums.xml
,
Aug 9 2017
Waiting for the UseCounter data.
,
Nov 1 2017
The NextAction date has arrived: 2017-11-01
,
Nov 16 2017
,
Jan 9 2018
> Usage shows 0% Yeah, I think we may change the behavior without sending intent-to-ship.
,
Jan 9 2018
,
Jan 16 2018
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea34d5887b9a78a94846321883f8fb537651aa06 commit ea34d5887b9a78a94846321883f8fb537651aa06 Author: Kent Tamura <tkent@chromium.org> Date: Wed Jan 17 22:22:46 2018 HTMLOptionsCollection's named property getter should not return NodeList. If the collection have multiple elements matched to the specified name, it should return the first one. The new behavior matches to Edge, Firefox and Safri. The NodeList behavior was almost unused according to the UseCounter. This CL removes fast/forms/select/named-options.html, because it is covered by the following tests: - external/wpt/html/infrastructure/common-dom-interfaces/collections/htmloptionscollection.html - external/wpt/html/semantics/forms/the-select-element/select-named-getter.html Bug: 695902 Change-Id: Ib2857d8ef6a0b68bbfae4e24d760976d855a544b Reviewed-on: https://chromium-review.googlesource.com/867810 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#529917} [delete] https://crrev.com/19e3c2e61f6e4864dbd1ba356b46cc70da36d4b6/third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/common-dom-interfaces/collections/htmloptionscollection-expected.txt [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/LayoutTests/fast/dom/html-collections-named-getter-expected.txt [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/LayoutTests/fast/dom/html-collections-named-getter.html [delete] https://crrev.com/19e3c2e61f6e4864dbd1ba356b46cc70da36d4b6/third_party/WebKit/LayoutTests/fast/forms/select/named-options-expected.txt [delete] https://crrev.com/19e3c2e61f6e4864dbd1ba356b46cc70da36d4b6/third_party/WebKit/LayoutTests/fast/forms/select/named-options.html [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/Source/core/html/forms/HTMLOptionsCollection.cpp [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/Source/core/html/forms/HTMLOptionsCollection.h [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/Source/core/html/forms/HTMLOptionsCollection.idl [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/ea34d5887b9a78a94846321883f8fb537651aa06/tools/metrics/histograms/enums.xml
,
Jan 18 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by foolip@chromium.org
, Mar 9 2017