Shelf snaps out of OVERLAP mode when moving overlapping window |
||||||||||
Issue descriptionSeen on Platform: 9310.0.0 Version: 58.3015.0 canary Board: veyron_minnie What steps will reproduce the problem? (1) Shelf state: Autohide off (2) Open a window and move it so it overlaps the shelf. The shelf should be visible, not just the buttons. (3) [attached video starts here] Drag the overlapping window. What is the expected result? - The shelf should stay visible What happens instead? - The shelf snaps to SHELF_BACKGROUND_DEFAULT ShelfBackgroundType
,
Feb 28 2017
Interesting, can you repro consistently on canary? Ben, any ideas here?
,
Mar 6 2017
,
Mar 14 2017
,
Mar 14 2017
Potential fix: https://codereview.chromium.org/2749123003/
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27dd2542a15215360c4f4fc8eeca9d72780d5167 commit 27dd2542a15215360c4f4fc8eeca9d72780d5167 Author: bruthig <bruthig@chromium.org> Date: Tue Mar 14 23:36:43 2017 [ash-md] Fixed ShelfBackgroundAnimator to not snap target values when being preempted. Snapping to the target values was causing the shelf to flicker when dragging a window while in OVERLAP mode. And on some platforms this contributed to the shelf incorrectly being painted as DEFAULT mode. BUG= 695901 Review-Url: https://codereview.chromium.org/2749123003 Cr-Commit-Position: refs/heads/master@{#456892} [modify] https://crrev.com/27dd2542a15215360c4f4fc8eeca9d72780d5167/ash/common/shelf/shelf_background_animator.cc [modify] https://crrev.com/27dd2542a15215360c4f4fc8eeca9d72780d5167/ash/common/shelf/shelf_background_animator.h [modify] https://crrev.com/27dd2542a15215360c4f4fc8eeca9d72780d5167/ash/common/shelf/shelf_background_animator_unittest.cc
,
Mar 17 2017
Does this need to be merged into M58?
,
Mar 17 2017
That's the plan. I'm just waiting to verify it in a Canary build before making the request.
,
Mar 23 2017
Verified on veyron_minnie canary 59.0.3049.0
,
Mar 23 2017
,
Mar 23 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3af2743961f2dd4424ec6f802d832e0b193d6556 commit 3af2743961f2dd4424ec6f802d832e0b193d6556 Author: Ben Ruthig <bruthig@chromium.org> Date: Thu Mar 23 19:00:22 2017 [ash-md] Fixed ShelfBackgroundAnimator to not snap target values when being preempted. Snapping to the target values was causing the shelf to flicker when dragging a window while in OVERLAP mode. And on some platforms this contributed to the shelf incorrectly being painted as DEFAULT mode. BUG= 695901 Review-Url: https://codereview.chromium.org/2749123003 Cr-Commit-Position: refs/heads/master@{#456892} (cherry picked from commit 27dd2542a15215360c4f4fc8eeca9d72780d5167) Review-Url: https://codereview.chromium.org/2768933003 . Cr-Commit-Position: refs/branch-heads/3029@{#391} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/3af2743961f2dd4424ec6f802d832e0b193d6556/ash/common/shelf/shelf_background_animator.cc [modify] https://crrev.com/3af2743961f2dd4424ec6f802d832e0b193d6556/ash/common/shelf/shelf_background_animator.h [modify] https://crrev.com/3af2743961f2dd4424ec6f802d832e0b193d6556/ash/common/shelf/shelf_background_animator_unittest.cc
,
Mar 23 2017
,
Mar 30 2017
Chrome OS 9334.28.0, 58.0.3029.40 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tbuck...@chromium.org
, Feb 27 2017Owner: tdander...@chromium.org
Status: Assigned (was: Available)