Connect VR omnibox to HTML virtual keyboard |
||
Issue descriptionWhen the HTML keyboard lands, the following needs to happen: - Keyboard should show when omnibox input field is focused - Keyboard should hide when omnibox input field is blurred (either by hitting other UI elements, or selecting a suggestion, etc) - That the keyboard and omnibox should not be coupled - omnibox needs to post a request for input, and the UI needs to react by enabling the keyboard.
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4fe824eb02d34107126ae84afe2edaff7c3c3c8 commit a4fe824eb02d34107126ae84afe2edaff7c3c3c8 Author: cjgrant <cjgrant@chromium.org> Date: Tue Mar 07 18:12:42 2017 Adjust HTML VKB positioning. - Keep the VKB from moving into the floor when not active. - Show the keyboard only in Menu mode. - Instead of moving the VK, for now, fade and shrink it when not active. - Rename 'uiElementId' to 'id' for convenient. BUG= 695898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2733103002 Cr-Commit-Position: refs/heads/master@{#455135} [modify] https://crrev.com/a4fe824eb02d34107126ae84afe2edaff7c3c3c8/chrome/browser/resources/vr_shell/vr_shell_ui.js
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b97438c4d7c950609a938cef8e791e2d8955d17f commit b97438c4d7c950609a938cef8e791e2d8955d17f Author: cjgrant <cjgrant@chromium.org> Date: Tue Mar 07 22:24:30 2017 Suppress the Android keyboard when selecting VR UI input fields. We already suppress the keyboard for the main WebContents; we need to do it for the UI WebContents as well. BUG= 695898 Review-Url: https://codereview.chromium.org/2736083002 Cr-Commit-Position: refs/heads/master@{#455252} [modify] https://crrev.com/b97438c4d7c950609a938cef8e791e2d8955d17f/chrome/browser/android/vr_shell/vr_shell.cc
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40128da8b2ed5bdf0a4e84c86b6fc03b2541718e commit 40128da8b2ed5bdf0a4e84c86b6fc03b2541718e Author: cjgrant <cjgrant@chromium.org> Date: Tue Mar 07 23:08:19 2017 Connect virtual keyboard to omnibox - When keyboard input events are generated, select the UI omnibox input field. This special case may live until we switch to a different keyboard implementation. - Move the content quad back in menu mode, as elements behind the content quad are not hittable. BUG= 695898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2735693006 Cr-Commit-Position: refs/heads/master@{#455275} [modify] https://crrev.com/40128da8b2ed5bdf0a4e84c86b6fc03b2541718e/chrome/browser/resources/vr_shell/vk.js [modify] https://crrev.com/40128da8b2ed5bdf0a4e84c86b6fc03b2541718e/chrome/browser/resources/vr_shell/vr_shell_ui.js
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8f38f56909bd1e53bda5538dee4b1800663de48 commit f8f38f56909bd1e53bda5538dee4b1800663de48 Author: cjgrant <cjgrant@chromium.org> Date: Thu Mar 09 21:39:34 2017 Separate VR omnibox and suggestion UI elements. By using separate elements for the omnibox and each suggestion, we fix the issue of having invisible suggestions intercept the reticle in front of the content window. BUG= 695898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2737183002 Cr-Commit-Position: refs/heads/master@{#455871} [modify] https://crrev.com/f8f38f56909bd1e53bda5538dee4b1800663de48/chrome/browser/resources/vr_shell/vr_shell_ui.css [modify] https://crrev.com/f8f38f56909bd1e53bda5538dee4b1800663de48/chrome/browser/resources/vr_shell/vr_shell_ui.js
,
Mar 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by cjgrant@chromium.org
, Feb 24 2017