New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695895 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Remove getter and setter in HTMLEmbedElement and HTMLObjectElement?

Project Member Reported by lunalu@chromium.org, Feb 24 2017

Issue description

Neither Gecko or WebKit have these APIs, nor the spec. Should we just remove them? 
 

Comment 1 by foolip@chromium.org, Feb 27 2017

Components: Blink>Bindings
Summary: Remove getter and setter in HTMLEmbedElement and HTMLObjectElement? (was: Remove getter and setter in HTMLObjectElement?)
The same pair is in HTMLEmbedElement, with a shared implementation in V8HTMLPlugInElementCustom.cpp. Adding Blink>Bindings because of that.

These should probably be removed and the first step would be to add use counters to see if these are actually used. Luna, do you want to do that?

Comment 2 by lunalu@chromium.org, Feb 27 2017

Owner: lunalu@chromium.org
Status: Assigned (was: Untriaged)
OK, I can do that. 
 Issue 695602  has been merged into this issue.

Comment 5 by lunalu@chromium.org, Jun 12 2017

Owner: loonyb...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: Hotlist-Interop
Cc: raymes@chromium.org raphael....@intel.com
+raymes

https://codereview.chromium.org/472243002 removed the call to v8::Value::Set() and https://codereview.chromium.org/640073005 put it back with a comment about the gTalk pepper plugin and it calling some deprecated API. I don't have access to bug 414842 for more context.

As far as I can see, a lot of code has been removed from V8HTMLPluginElementCustom over the years, and the exiting named property getter and setter are there essentially to support setting and retrieving data from an HTMLPlugInElement's PluginWrapper(). Since setting data was supposed to be a temporary measure for something that happened 3.5 years ago I wonder if we can get rid of it now.

On the other hand, usage data for HTML{Element,Object}{Getter,Setter} is pretty high so it's really unclear if it was only the gTalk plugin that was using this infrastructure.
AFAIK the gtalk plugin is long gone so whatever was needed for it can probably be removed.

Sign in to add a comment