Remove getter and setter in HTMLEmbedElement and HTMLObjectElement? |
||||||
Issue descriptionNeither Gecko or WebKit have these APIs, nor the spec. Should we just remove them?
,
Feb 27 2017
OK, I can do that.
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4ac2e9a324a943abe94c8161273904c53bc02b3 commit e4ac2e9a324a943abe94c8161273904c53bc02b3 Author: lunalu <lunalu@chromium.org> Date: Tue Feb 28 23:42:13 2017 Added use counters for getter and setter in HTMLEmbedElement and HTMLObjectElement BUG=695895 Review-Url: https://codereview.chromium.org/2721463004 Cr-Commit-Position: refs/heads/master@{#453744} [modify] https://crrev.com/e4ac2e9a324a943abe94c8161273904c53bc02b3/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp [modify] https://crrev.com/e4ac2e9a324a943abe94c8161273904c53bc02b3/third_party/WebKit/Source/core/frame/UseCounter.h
,
Mar 9 2017
Issue 695602 has been merged into this issue.
,
Jun 12 2017
,
Sep 1 2017
,
Mar 3 2018
,
Mar 30 2018
+raymes https://codereview.chromium.org/472243002 removed the call to v8::Value::Set() and https://codereview.chromium.org/640073005 put it back with a comment about the gTalk pepper plugin and it calling some deprecated API. I don't have access to bug 414842 for more context. As far as I can see, a lot of code has been removed from V8HTMLPluginElementCustom over the years, and the exiting named property getter and setter are there essentially to support setting and retrieving data from an HTMLPlugInElement's PluginWrapper(). Since setting data was supposed to be a temporary measure for something that happened 3.5 years ago I wonder if we can get rid of it now. On the other hand, usage data for HTML{Element,Object}{Getter,Setter} is pretty high so it's really unclear if it was only the gTalk plugin that was using this infrastructure.
,
Apr 2 2018
AFAIK the gtalk plugin is long gone so whatever was needed for it can probably be removed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by foolip@chromium.org
, Feb 27 2017Summary: Remove getter and setter in HTMLEmbedElement and HTMLObjectElement? (was: Remove getter and setter in HTMLObjectElement?)