New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695891 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Standardize or remove HTMLFrameSetElement's anonymous getter

Project Member Reported by lunalu@chromium.org, Feb 24 2017

Issue description

Neither Gecko or WebKit has it, should we just remove it?
 
Summary: Standardize or remove HTMLFrameSetElement's anonymous getter (was: Remove non-standard API HTMLFrameSetElement#getter)
The implementation of this is HTMLFrameSetElement::anonymousNamedGetter. Based on that, here's a test to check for support:
https://software.hixie.ch/utilities/js/live-dom-viewer/saved/4928

It's supported in Chromium and WebKit, but not Gecko or EdgeHTML.

Given this, measuring how often this getter returns anything other than undefined (null internally) would be a good start. Luna?
Cc: foolip@chromium.org

Comment 3 by tkent@chromium.org, Mar 9 2017

Labels: Hotlist-Interop
Status: Available (was: Untriaged)
Owner: shanmug...@samsung.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/026ac85facd73a803f14af641d3f5ef26c2953b5

commit 026ac85facd73a803f14af641d3f5ef26c2953b5
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Mon Nov 20 10:22:21 2017

Measure HTMLFrameSetElement's non-null anonymous name getter

This patch measures how often getter returns anything
other than non null.

Bug:  695891 
Change-Id: I62ea96d6ccf9c0dea0804dcab221e71b55ffca37
Reviewed-on: https://chromium-review.googlesource.com/773520
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517789}
[modify] https://crrev.com/026ac85facd73a803f14af641d3f5ef26c2953b5/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp
[modify] https://crrev.com/026ac85facd73a803f14af641d3f5ef26c2953b5/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/026ac85facd73a803f14af641d3f5ef26c2953b5/tools/metrics/histograms/enums.xml

This non-standard getter was added 13 years ago to fix a compatibility issue at the time: https://trac.webkit.org/changeset/8717/webkit

The commit above is present since M64, and according to https://www.chromestatus.com/metrics/feature/timeline/popularity/2235 usage never goes above 0.0001%.

Shanmuga, are you going to follow up and consider deprecating+removing this?
Cc: shanmug...@samsung.com
Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Started)
Marking as available. In httparchive, it looks like there aren't any pages that hit the HTMLFrameSetElementNonNullAnonymousNamedGetter counter during page load:
https://bigquery.cloud.google.com/savedquery/762219082167:df7f9e5098ad45808a3e398e4adb13c7

Given the low overall usage, and the fact that this is measuring the getter and we can't tell how the non-null return value is used, if at all, I would support deprecation and removal of this.
Owner: hs1217....@samsung.com
Status: Assigned (was: Available)
i will proceed to deprecate and remove this feature.
Project Member

Comment 9 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a3fd5d28f223b18d5d8660aa57ce190678b921

commit b7a3fd5d28f223b18d5d8660aa57ce190678b921
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Wed May 23 15:00:21 2018

notify a deprecation message for anonymous getter

notify a deprecation message for HTMLFrameSetElement's
anonymous getter to user before remove it.
this feature will be removed at m70.

Bug:  695891 
Change-Id: Iae0c0848bed691d2b3cc472a1c515c3e926c176c
Reviewed-on: https://chromium-review.googlesource.com/1070170
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561083}
[modify] https://crrev.com/b7a3fd5d28f223b18d5d8660aa57ce190678b921/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/b7a3fd5d28f223b18d5d8660aa57ce190678b921/third_party/blink/renderer/core/frame/deprecation.cc
[modify] https://crrev.com/b7a3fd5d28f223b18d5d8660aa57ce190678b921/third_party/blink/renderer/core/html/html_frame_set_element.cc
[modify] https://crrev.com/b7a3fd5d28f223b18d5d8660aa57ce190678b921/tools/metrics/histograms/enums.xml

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 9

Status: Fixed (was: Started)

Sign in to add a comment