[Chrome Home] The bottom sheet can be closed while a context menu from inside it is opened |
||||
Issue descriptionRepro: 1. Open the bottom sheet (set the Chrome Home flag, etc) 2. Long press on a suggestion, the context menu should come up 3. Without releasing your finger, move it up or down. Expected: nothing happens Actual: The sheet opens further or starts closing depending on the direction of the swipe. Additional information: On L+ the non modal context menu slowly closes when moving too far away, but it is still possible to repro sometimes. For the suggestions on the NTP we explicitly intercept touches on the recyclerview to avoid undesired interactions when the context menu is open (see issue 650153). Something similar could be done with the bottom sheet, or we can try to find a more general solution.
,
Apr 3 2017
,
Apr 10 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bdd60bde9cc56d72767bb7e13b777fd47074006 commit 6bdd60bde9cc56d72767bb7e13b777fd47074006 Author: mvanouwerkerk <mvanouwerkerk@chromium.org> Date: Wed Apr 12 10:02:50 2017 [Home] Disable BottomSheet touches while context menu is open. BUG= 695818 Review-Url: https://codereview.chromium.org/2810713002 Cr-Commit-Position: refs/heads/master@{#463979} [modify] https://crrev.com/6bdd60bde9cc56d72767bb7e13b777fd47074006/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java [modify] https://crrev.com/6bdd60bde9cc56d72767bb7e13b777fd47074006/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/6bdd60bde9cc56d72767bb7e13b777fd47074006/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [modify] https://crrev.com/6bdd60bde9cc56d72767bb7e13b777fd47074006/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java [modify] https://crrev.com/6bdd60bde9cc56d72767bb7e13b777fd47074006/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
Apr 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgn@chromium.org
, Mar 1 2017