New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695807 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Custom Tabs WebContents render initialization can be initiated as soon as WebContents is created

Project Member Reported by trevordixon@chromium.org, Feb 24 2017

Issue description

The WebContents created in CustomTabActivity.java will certainly navigate to a page and need a renderer, so there's no reason to delay renderer initialization. Currently `WebContentsFactory.createWebContents` is called, but an existing method `WebContentsFactory.createWebContentsWithWarmRenderer` will trigger render initialization sooner.
 

Comment 1 by lizeb@chromium.org, Feb 24 2017

Components: UI>Browser>Mobile>CustomTabs
Labels: Performance
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60c2e708f18b501cfbea9a3d9a5a8ef8a5a3d9e4

commit 60c2e708f18b501cfbea9a3d9a5a8ef8a5a3d9e4
Author: trevordixon <trevordixon@chromium.org>
Date: Mon Feb 27 13:26:56 2017

customtabs: Intialize renderer at WebContents creation time.

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG= 695807 

Review-Url: https://codereview.chromium.org/2714073003
Cr-Commit-Position: refs/heads/master@{#453200}

[modify] https://crrev.com/60c2e708f18b501cfbea9a3d9a5a8ef8a5a3d9e4/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Status: Fixed (was: Started)

Sign in to add a comment