New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695801 link

Starred by 3 users
Status: Fixed
Owner:
█ magjed@chromium.org
Last visit 16 days ago
Closed: Feb 2017
Cc:
█ noahric@chromium.org
█ tlegrand@chromium.org
█ magjed@chromium.org
holmer@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

WebRTC external codec list grows every time supported_codecs is called

Project Member Reported by magjed@chromium.org, Feb 24 2017 
The corresponding WebRTC issue is here: https://bugs.chromium.org/p/webrtc/issues/detail?id=7020.

What steps will reproduce the problem?
(1) Use e.g. Hangouts or some other WebRTC service in Chrome.
(2) Wait a while.

What is the expected result?
The list of codecs supported by the external encoder factory should be the same every time it's called.

What happens instead?
[902.535s] Codecs supported by the external encoder factory: H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, H264, ...

The fix for this landed in https://codereview.webrtc.org/2639423006 one month ago. We want to merge the fix to M57. The fix is trivial.
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 25 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by magjed@chromium.org, Feb 25 2017

Labels: Merge-Merged
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/52b6562a10b495cf771d8388ee51990d56074059

commit 52b6562a10b495cf771d8388ee51990d56074059
Author: Magnus Jedvert <magjed@webrtc.org>
Date: Sat Feb 25 19:12:18 2017

Merge to 57: Clear out cached codecs when calculating new codec lists.

Without this, every time WebRtcVideoEngine2 calls supported_codecs(),
the codec list grows.

BUG= webrtc:7020 

Original Review-Url: https://codereview.webrtc.org/2639423006
Original Cr-Commit-Position: refs/heads/master@{#16178}
(cherry picked from commit be850e1b1de5bf046080ac1df7de67a3d6d12d1c)

Review-Url: https://codereview.webrtc.org/2717053002 .
Cr-Commit-Position: refs/branch-heads/57@{#7}
Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}

[modify] https://crrev.com/52b6562a10b495cf771d8388ee51990d56074059/webrtc/media/BUILD.gn
[modify] https://crrev.com/52b6562a10b495cf771d8388ee51990d56074059/webrtc/media/engine/webrtcvideoencoderfactory.cc
[add] https://crrev.com/52b6562a10b495cf771d8388ee51990d56074059/webrtc/media/engine/webrtcvideoencoderfactory_unittest.cc

Comment 3 by gov...@chromium.org, Feb 26 2017

Labels: -Merge-Merged -Merge-Approved-57 merge-merged-57
Per comment #2, this is already merged to M57. Hence removing "Merge-Approved-57" label.

Comment 4 by magjed@chromium.org, Mar 3 2017

Cc: magjed@chromium.org
 Issue 697689  has been merged into this issue.
►

Sign in to add a comment