New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695789 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Read configs from luci-config

Project Member Reported by emso@chromium.org, Feb 24 2017

Issue description

Test configs have been added to tricium config for the infra project. Replace any tmp configs in the code with configs from luci-config.
 

Comment 1 by emso@chromium.org, Feb 24 2017

Labels: Tricium Milestone-Hello

Comment 2 by emso@chromium.org, Feb 24 2017

Labels: -Pri-3 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dc2cf7f80d5ab359f36117d847a0e289eb45ea44

commit dc2cf7f80d5ab359f36117d847a0e289eb45ea44
Author: Emma <emso@chromium.org>
Date: Mon Mar 27 15:59:01 2017

Refactors common config code and connects to LUCI-config.

BUG= 695789 

Change-Id: Iba7822db8743c830602ab1557baa6a0eb1af56ea
Reviewed-on: https://chromium-review.googlesource.com/457061
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/tracker/rpc_worker_launched_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/tracker/rpc_worker_done_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/driver/rpc_trigger_test.go
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/config/provider.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/config/rpc_validate.go
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/config/validate.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/gerrit-poller/handlers.go
[rename] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/config/generate_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/config_helpers_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/frontend/rpc_analyze.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/common.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/driver/rpc_trigger.go
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/devcfg/services/tricium-dev/service.cfg
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/config.proto
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/devcfg/projects/playground-gerrit-tricium/tricium-dev.cfg
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/launcher/rpc_launch.go
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/devcfg/projects/infra/tricium-dev.cfg
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/config_helpers.go
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/config/generate.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/tricium.pb.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/config.pb.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/config/config.infra_testing
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/driver/rpc_collect_test.go
[rename] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/config/validate_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/config/rpc_generate_workflow.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/data.pb.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/frontend/handlers.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/driver/rpc_collect.go
[add] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/common/config/config.infra_testing
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/launcher/rpc_launch_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched_test.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/api/v1/platform.pb.go
[modify] https://crrev.com/dc2cf7f80d5ab359f36117d847a0e289eb45ea44/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/c50fc341a600ba7344840e72682ca025c3173021

commit c50fc341a600ba7344840e72682ca025c3173021
Author: Emma Soederberg <emso@google.com>
Date: Thu Mar 30 12:21:10 2017

Comment 5 by emso@chromium.org, Apr 28 2017

Status: Verified (was: Assigned)

Sign in to add a comment