New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695783 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Tab crash is seen on selecting offline checkbox in Devtools

Project Member Reported by ratnavar...@techmahindra.com, Feb 24 2017

Issue description

Chrome Version:58.0.3022.0 dev
OS:Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome, goto NTP and Open Devtools
(2)Go to network tab, press F5 and Check/uncheck offline checkbox and Observe
Expected Result:No crash should occur on selecting offline checkbox in Devtools
Actual Result:Crash occurs on selecting offline checkbox in Devtools

This is a Regression issue broken in M-58
manual Bisect Info:
===================
Good build:58.0.3021.0 dev
Bad build :58.0.3022.0 dev

Windows behaviour will be updated soon.
 
Labels: OS-Windows
Issue is also seen in Windows.
Actual.ogv
1.6 MB View Download
Labels: -Needs-Bisect hasbisect-per-revision
Owner: kinuko@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build -- 58.0.3021.0 (revision : 452347)
Bad Build  -- 58.0.3022.0 (revision : 452713)

You are probably looking for a change made after 452510 (known good), but no later than 452511 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d0b0e164df66904125ecdcf3473212a1d97a11ce..fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d

@kinuko -- Could you please look into the issue, kindly re-assign if this is not related to your changes.

Thank You.

Comment 3 by kinuko@chromium.org, Feb 24 2017

Labels: -OS-Linux -OS-Windows OS-All
Status: Started (was: Assigned)
Could reproduce on Mac, looking.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef33cbc2c4e56e2aa5c1503b7cbaf0b826c3affe

commit ef33cbc2c4e56e2aa5c1503b7cbaf0b826c3affe
Author: kinuko <kinuko@chromium.org>
Date: Fri Feb 24 18:08:10 2017

NetworkStateNotifier: also remove NetworkStateObserver in finalizer too

I was wrong that contextDestroy is not always called before the
document gets destructed.

Make sure we remove NetworkStateNotifier in finalizer too to avoid crash.

BUG= 695783 
TEST=See the bug for repro

Review-Url: https://codereview.chromium.org/2714643008
Cr-Commit-Position: refs/heads/master@{#452870}

[modify] https://crrev.com/ef33cbc2c4e56e2aa5c1503b7cbaf0b826c3affe/third_party/WebKit/Source/core/dom/Document.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e78ba0f584de89a6abc55d43c283fb16a4b3afd

commit 6e78ba0f584de89a6abc55d43c283fb16a4b3afd
Author: kinuko <kinuko@chromium.org>
Date: Mon Feb 27 10:41:40 2017

Don't attach NetworkStateObserver until Document is initialized/attached

BUG= 695783 
TEST=See the bug page

Review-Url: https://codereview.chromium.org/2719873002
Cr-Commit-Position: refs/heads/master@{#453183}

[modify] https://crrev.com/6e78ba0f584de89a6abc55d43c283fb16a4b3afd/third_party/WebKit/Source/core/dom/Document.cpp

Issue is not reproducible on latest #59.0.3036.0 for Windows,Ubuntu 14.04

Comment 7 by ajha@chromium.org, Mar 9 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3036.0
Verified the fix on the latest Mac canary(59.0.3036.0) as well. This is working as intended and no crash is seen. Adding the verified label for M-59.

kinuko@: Could you please close the issue if there is no further work to be done here. No merge required here as the fix landed before M-58 branch point(#454471)

Comment 8 by kinuko@chromium.org, Mar 10 2017

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
No merge is needed per comment #7 and it is if fixed per comment #8. 

Sign in to add a comment