New issue
Advanced search Search tips

Issue 695776 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 698633
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 590369



Sign in to add a comment

Get rid of FrameSelection::computeVisibleSelectionInDOMTreeDeprecated()

Project Member Reported by yosin@chromium.org, Feb 24 2017

Issue description

We should replace |computeVisibleSelectionInDOMTreeDeprecated()| into
 1 document().updateStyleAndLayoutIgnorePendingStylesheets() with hoisting
 2 computeVisibleSelectionInDOMTee()

As of Feb 24, 2017, there are 240+ call sites.  (^_^;)




 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f

commit 4130eea2c32a5d3e0014ee9de21c16b2a55bb09f
Author: yosin <yosin@chromium.org>
Date: Fri Feb 24 14:15:46 2017

Introduce rootEditableElementOrTreeScopeRootNodeOf() as replacement of FrameSelection member

This patch Introduces |rootEditableElementOrTreeScopeRootNodeOf()| as replacement
of |FrameSelection::rootEditableElementOrTreeScopeRootNode()| to hoist
|computeVisibleSelectionInDOMTreeDeprecated()| and simplify |FrameSelection|
for improving code health.

BUG= 695776 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2715913002
Cr-Commit-Position: refs/heads/master@{#452816}

[modify] https://crrev.com/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/4130eea2c32a5d3e0014ee9de21c16b2a55bb09f/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48aff7a40b37530a9f0c63e7169fecab3bf685d1

commit 48aff7a40b37530a9f0c63e7169fecab3bf685d1
Author: yosin <yosin@chromium.org>
Date: Fri Feb 24 14:18:18 2017

Introduce computePositionForNodeRemoval() as replacement of updatePositionForNodeRemoval()

This patch Introduces |computePositionForNodeRemoval()| as replacement of
|updatePositionForNodeRemoval()| to avoid using side-effect function to align
with other parts of code for improving code health.

BUG= 695776 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2691913002
Cr-Commit-Position: refs/heads/master@{#452818}

[modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
[modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Mergedinto: 698633
Status: Duplicate (was: Available)

Sign in to add a comment