Issue metadata
Sign in to add a comment
|
Get rid of FrameSelection::computeVisibleSelectionInDOMTreeDeprecated() |
||||||||||||||||||||||||
Issue descriptionWe should replace |computeVisibleSelectionInDOMTreeDeprecated()| into 1 document().updateStyleAndLayoutIgnorePendingStylesheets() with hoisting 2 computeVisibleSelectionInDOMTee() As of Feb 24, 2017, there are 240+ call sites. (^_^;)
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48aff7a40b37530a9f0c63e7169fecab3bf685d1 commit 48aff7a40b37530a9f0c63e7169fecab3bf685d1 Author: yosin <yosin@chromium.org> Date: Fri Feb 24 14:18:18 2017 Introduce computePositionForNodeRemoval() as replacement of updatePositionForNodeRemoval() This patch Introduces |computePositionForNodeRemoval()| as replacement of |updatePositionForNodeRemoval()| to avoid using side-effect function to align with other parts of code for improving code health. BUG= 695776 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2691913002 Cr-Commit-Position: refs/heads/master@{#452818} [modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp [modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/EditingUtilities.h [modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/SelectionEditor.cpp [modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp [modify] https://crrev.com/48aff7a40b37530a9f0c63e7169fecab3bf685d1/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
,
Jul 26 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Feb 24 2017