New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695761 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Compile Failure on Mac# 58.0.3022.0

Project Member Reported by msrchandra@chromium.org, Feb 24 2017

Issue description

Link to Builds:
===============
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1543

Link to Log File:
=================
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1543/steps/compile/logs/stdio

Error from the Log:
===================
FAILED: WidevineCdm/_platform_specific/mac_x64/widevinecdmadapter.plugin.sig 
python ../../third_party/widevine/scripts/signature_generator.py --input_file WidevineCdm/_platform_specific/mac_x64/widevinecdmadapter.plugin --output_file WidevineCdm/_platform_specific/mac_x64/widevinecdmadapter.plugin.sig
Traceback (most recent call last):
  File "../../third_party/widevine/scripts/signature_generator.py", line 120, in <module>
    args.passphrase_debug, args.flags))
  File "../../third_party/widevine/scripts/signature_generator.py", line 76, in _GenerateSignatureFile
    import signer
  File "/b/build/slave/mac64/build/src/third_party/widevine/scripts/signer.py", line 17, in <module>
    from cryptography import x509
ImportError: No module named cryptography
[15479/50240] CC obj/third_party/yasm/yasm/nasm-token.o
[15480/50240] LINK ./crdmg
[15481/50240] CXX obj/tools/gn/gn_lib/c_include_iterator.o
[15482/50240] CXX obj/tools/gn/gn_lib/builder_record.o
[15483/50240] CXX obj/tools/gn/gn_lib/action_values.o
[15484/50240] CXX obj/third_party/woff2/woff2_dec/woff2_dec.o
[15485/50240] CXX obj/tools/gn/gn_lib/build_settings.o
[15486/50240] CC obj/third_party/yasm/yasm/nasm-pp.o
[15487/50240] CXX obj/tools/gn/gn_lib/bundle_file_rule.o
[15488/50240] CXX obj/tools/gn/gn_lib/bundle_data_target_generator.o
[15489/50240] CXX obj/tools/gn/gn_lib/action_target_generator.o
[15490/50240] CC obj/third_party/yasm/yasm/bitvect.o
[15491/50240] CXX obj/tools/gn/gn_lib/command_analyze.o
[15492/50240] CXX obj/tools/gn/gn_lib/err.o
[15493/50240] CXX obj/tools/gn/gn_lib/binary_target_generator.o
[15494/50240] CXX obj/tools/gn/gn_lib/command_clean.o
[15495/50240] CXX obj/tools/gn/gn_lib/args.o
[15496/50240] CXX obj/tools/gn/gn_lib/bundle_data.o
[15497/50240] CXX obj/tools/gn/gn_lib/command_check.o
[15498/50240] CXX obj/tools/gn/gn_lib/command_args.o
[15499/50240] CXX obj/tools/gn/gn_lib/builder.o
[15500/50240] CXX obj/tools/gn/gn_lib/command_desc.o
[15501/50240] CXX obj/tools/gn/gn_lib/command_gen.o
[15502/50240] CXX obj/tools/gn/gn_lib/analyzer.o
[15503/50240] CXX obj/tools/gn/gn_lib/command_format.o
ninja: build stopped: subcommand failed.

/b/build/scripts/slave/gsutil cp file:///tmp/tmpAfeFoC gs://chrome-goma-log/2017/02/24/osx-3-m0/ninja_log.osx-3-m0.chrome-bot.20170223-202806.49450.gz
Copying file:///tmp/tmpAfeFoC [Content-Type=application/octet-stream]...
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 0 B/399.55 KiB    
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 72 KiB/399.55 KiB    
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 144 KiB/399.55 KiB    
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 216 KiB/399.55 KiB    
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 288 KiB/399.55 KiB    
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 360 KiB/399.55 KiB    
Uploading   ...log.osx-3-m0.chrome-bot.20170223-202806.49450.gz: 399.55 KiB/399.55 KiB    
Copied log file to gs://chrome-goma-log/2017/02/24/osx-3-m0/ninja_log.osx-3-m0.chrome-bot.20170223-202806.49450.gz
Visualization at http://chromium-build-stats.appspot.com/ninja_log/2017/02/24/osx-3-m0/ninja_log.osx-3-m0.chrome-bot.20170223-202806.49450.gz
program finished with exit code 1
elapsedTime=1075.186826

Assigning to the concern owner from the below CL --
https://chromium.googlesource.com/chromium/src/+log/58.0.3021.0..58.0.3022.0?pretty=fuller&n=10000

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/5762e61a17e4e05c490be128fd96204f24c1a457

@jrummell -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

 
Cc: sebmarchand@chromium.org
Components: Build
Labels: ReleaseBlock-Dev

Comment 2 by rsesek@chromium.org, Feb 24 2017

Cc: rsesek@chromium.org
Reverting this here: https://codereview.chromium.org/2714643009/. Widevine's signer script is using python modules that don't exist in a default installation.

Comment 3 by rsesek@chromium.org, Feb 24 2017

Revert landed: https://chromium.googlesource.com/chromium/src/+/72d281d8c6fc0e2c94c2545c7d6c7ad7409324e7

Please trigger another official build when you're ready.

Comment 4 by xhw...@chromium.org, Feb 24 2017

Issue 695766 has been merged into this issue.
rsesek@, thank you for the revert. Can you please merge this revert to 3022 branch? I'm planning to trigger a new Mac Canary from the same branch.

PS: You do not need to follow any 'Merge-Approval' process since 3022 is yet to be branched officially.

Thank you!
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 24 2017

Labels: merge-merged-3022
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d774c481f48e6c49ec929207ae6c376143022b93

commit d774c481f48e6c49ec929207ae6c376143022b93
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Feb 24 18:24:54 2017

Revert of Add Widevine signature files into Mac build (patchset #8 id:140001 of https://codereview.chromium.org/2647393004/ )

Reason for revert:
Broke official build  https://crbug.com/695761 

BUG= 695761 

Original issue's description:
> Add Widevine signature files into Mac build
>
> On official Mac builds Widevine is included in the app. This change adds
> the matching signature files needed by Widevine.
>
> BUG=684871
> TEST=signature files created in the correct place when is_official_build
>
> Review-Url: https://codereview.chromium.org/2647393004
> Cr-Commit-Position: refs/heads/master@{#452603}
> Committed: https://chromium.googlesource.com/chromium/src/+/5762e61a17e4e05c490be128fd96204f24c1a457

TBR=xhwang@chromium.org,rkuroiwa@chromium.org,kerrnel@chromium.org,dpranke@chromium.org,jrummell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684871

Review-Url: https://codereview.chromium.org/2714643009
Cr-Commit-Position: refs/heads/master@{#452832}
(cherry picked from commit 72d281d8c6fc0e2c94c2545c7d6c7ad7409324e7)

Review-Url: https://codereview.chromium.org/2705193006 .
Cr-Commit-Position: refs/branch-heads/3022@{#3}
Cr-Branched-From: 55a8e3f7414855960a20135217d32de930466f3d-refs/heads/master@{#452713}

[modify] https://crrev.com/d774c481f48e6c49ec929207ae6c376143022b93/chrome/BUILD.gn
[modify] https://crrev.com/d774c481f48e6c49ec929207ae6c376143022b93/third_party/widevine/cdm/BUILD.gn
[modify] https://crrev.com/d774c481f48e6c49ec929207ae6c376143022b93/third_party/widevine/cdm/widevine.gni

Thank you for the quick merge. Triggered a new canary for Mac from 3022.
Cc: abdulsyed@chromium.org

Comment 9 by rsesek@chromium.org, Feb 24 2017

Status: Fixed (was: Assigned)
58.0.3022.3 released.
Status: Verified (was: Fixed)
next canary builds successfully compiled and available, closing the issue.

Sign in to add a comment