New issue
Advanced search Search tips

Issue 695751 link

Starred by 2 users
Status: Fixed
Owner:
msw@chromium.org
Closed: Oct 2017
Cc:
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 693114



Sign in to add a comment

Number of ShelfView (include ShelfViewInkDropTest and WmShelfObserverIconTest) fail in mash

Project Member Reported by sky@chromium.org, Feb 24 2017 
Note sure if this indicates the test needs to be updated for mash, or a more fundamental problem.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98d7a599f145f9e5ad5b5f6a47dc1998045f16c8

commit 98d7a599f145f9e5ad5b5f6a47dc1998045f16c8
Author: sky <sky@chromium.org>
Date: Tue Feb 28 00:18:35 2017

mash: makes OverflowButtonActiveInkDropTest.TouchContextMenu early out

It appears to be flaky.

BUG= 696769 , 695751 
TEST=test only change
R=msw@chromium.org
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2719973003
Cr-Commit-Position: refs/heads/master@{#453408}

[modify] https://crrev.com/98d7a599f145f9e5ad5b5f6a47dc1998045f16c8/ash/shelf/shelf_view_unittest.cc

Comment 5 by sky@chromium.org, Mar 1 2017

Status: Assigned (was: Untriaged)

Comment 6 by sky@chromium.org, Mar 7 2017

Blocking: 693114
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69

commit eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69
Author: sky <sky@chromium.org>
Date: Wed Mar 22 23:24:18 2017

Makes AshTestHelper shutdown ChromeOS NetworkHandler

Classic ash unittests don't run with the NetworkHandler running. To
run with the NetworkHandler triggers additional items on the tray,
which tests are not setup to deal correctly with.

BUG= 695751 , 696769 
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2772513003
Cr-Commit-Position: refs/heads/master@{#458927}

[modify] https://crrev.com/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69/ash/mus/window_manager_application.cc
[modify] https://crrev.com/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69/ash/mus/window_manager_application.h
[modify] https://crrev.com/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69/ash/test/ash_test_helper.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7

commit b3a073579dffb23de8ebe1f181361b7f2a3d1ba7
Author: Mike Wasserman <msw@chromium.org>
Date: Tue Aug 22 23:25:14 2017

mash: Fix the app list button's ink drop deactivation.

Always use AppListDelegateImpl for Shell AppList notifications.
(avoid AppListPresenterDelegate[Mus] duplication/disparity)

Remove the delegate removal TODO, may relate to crbug.com/733662
(the delegate may be necessary until ui/app_list moves into ash)

Fix root window checks (they're null for invalid/old display ids).

Rename TestAppListPresenterImpl, connect with the ash app list.
Add helpers to spin a run loop on app list show/dismiss (via mojo).

Enable numerous tests on Mash that rely on the presenter, etc.
Avoid mock app list notifications when possible in tests.

Bug:  730887 ,  696028 ,  695751 
Change-Id: I19a3f8adc7ca66a7ad81fb254198c96fb4428ae3
Reviewed-on: https://chromium-review.googlesource.com/624515
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496502}
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/BUILD.gn
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/app_list/app_list_delegate_impl.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/app_list/app_list_presenter_delegate_unittest.cc
[add] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/app_list/test_app_list_presenter_impl.cc
[add] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/app_list/test_app_list_presenter_impl.h
[delete] https://crrev.com/a48fd5adbbe586213bbca80cb10cc83aaa705e70/ash/app_list/test_app_list_view_presenter_impl.cc
[delete] https://crrev.com/a48fd5adbbe586213bbca80cb10cc83aaa705e70/ash/app_list/test_app_list_view_presenter_impl.h
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/shelf/app_list_button.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/shell.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/b3a073579dffb23de8ebe1f181361b7f2a3d1ba7/ui/app_list/presenter/app_list_presenter_impl.h

Comment 9 by msw@chromium.org, Aug 22 2017 

There are still three tests that are left disabled in mash for this bug:
  ShelfObserverIconTest.AddRemoveWithMultipleDisplays
  ShelfViewTest.Launcher_ButtonPressedUserActionsRecordedWhenItemSelected
  ShelfViewTest.Launcher_TaskUserActionsRecordedWhenItemSelected
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1412591ef099e183ca5f641a11761786727399da

commit 1412591ef099e183ca5f641a11761786727399da
Author: Mike Wasserman <msw@chromium.org>
Date: Mon Oct 16 20:39:08 2017

mash: Enable remaining ShelfView unit tests in mash.

Remove shelf_view_unittests.cc early retuns for the mash config.

Bug:  695751 
Change-Id: I8b478b87d56b75365b154677a2eece689780a56b
Reviewed-on: https://chromium-review.googlesource.com/721691
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509158}
[modify] https://crrev.com/1412591ef099e183ca5f641a11761786727399da/ash/shelf/shelf_view_unittest.cc

Comment 11 by msw@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 13 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment