New issue
Advanced search Search tips

Issue 695744 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

presubmit warnings of unit test source format

Project Member Reported by xing...@intel.com, Feb 24 2017

Issue description

In cl https://codereview.chromium.org/2708153005/, when git cl upload, it will prompts: 
presubmit warnings:  The src directory requires source formatting. Please run git cl format 

If run git cl format, it will format file content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc and move  
#include "content/browser/renderer_host/offscreen_canvas_surface_manager.h" to
the first line.

However, for file offscreen_canvas_surface_manager_unittest.cc, it doesn't have a offscreen_canvas_surface_manager_unittest.h. 

So suggest git cl format take .cc file without .h as a special case.
 

Comment 1 by xing...@intel.com, Feb 24 2017

Components: Infra
Components: -Infra Infra>Codereview
Status: Available (was: Untriaged)
Cc: thakis@chromium.org
Components: -Infra>Codereview
Labels: clang-format
Status: Archived (was: Available)

Sign in to add a comment