CaptureScreenshotTest.CaptureScreenshotArea started being flaky after r452648 |
|||
Issue descriptionI can reproduce this locally with linux debug build with ./out/Debug/content_browsertests --gtest_repeat=20 --gtest_filter=CaptureScreenshotTest.CaptureScreenshotArea Syncing to r452647 makes test runs pass. This is currently failing or being flaky on multiple bots, some examples. 1) Linux Tests (dbg)(1)(32) content_browsertests: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1__32_%2F38774%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Flogs%2FCaptureScreenshotTest.CaptureScreenshotArea%2F0 2) Linux Tests (dbg)(1) https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29 browser_side_navigation_content_browsertests: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1_%2F61152%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_content_browsertests%2F0%2Flogs%2FCaptureScreenshotTest.CaptureScreenshotArea%2F0 site_per_process_content_browsertests: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1_%2F61152%2F%2B%2Frecipes%2Fsteps%2Fsite_per_process_content_browsertests%2F0%2Flogs%2FCaptureScreenshotTest.CaptureScreenshotArea%2F0
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/208c75a57f289ba9e0fc10582179320900ad77e5 commit 208c75a57f289ba9e0fc10582179320900ad77e5 Author: lazyboy <lazyboy@chromium.org> Date: Fri Feb 24 01:43:21 2017 Revert of Getting rid of immediate ack in DelegatedFrameHost (patchset #2 id:20001 of https://codereview.chromium.org/2710263002/ ) Reason for revert: This CL is likely causing CaptureScreenshotTest.CaptureScreenshotArea test failures. See more details at https://bugs.chromium.org/p/chromium/issues/detail?id=695718 BUG= 695718 Original issue's description: > Getting rid of immediate ack in DelegatedFrameHost > > When DelegatedFrameHost receives a frame from the renderer that does not > have the right size, it sends back an ack immediately so that the > renderer sends a new frame (hopefully with the right size) as soon as > possible. The problem is that this feature relies on SubmitCompositorFrame > taking an ack callback which will no longer be true once we switch to > CompositorFrameSinkSupport. This CL removes the immediate ack feature > altogether. I tested this change and I could not see a noticable > difference in resize latency. > > BUG= 692880 > > Review-Url: https://codereview.chromium.org/2710263002 > Cr-Commit-Position: refs/heads/master@{#452648} > Committed: https://chromium.googlesource.com/chromium/src/+/8e0074effadf2beceb5df755b7e61ef095cde7a1 TBR=fsamuel@chromium.org,jbauman@chromium.org,jam@chromium.org,samans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 692880 Review-Url: https://codereview.chromium.org/2713553013 Cr-Commit-Position: refs/heads/master@{#452710} [modify] https://crrev.com/208c75a57f289ba9e0fc10582179320900ad77e5/content/browser/renderer_host/delegated_frame_host.cc
,
Feb 24 2017
,
Feb 24 2017
Issue 695748 has been merged into this issue.
,
Feb 24 2017
The revert seems to have done the trick :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by lazyboy@chromium.org
, Feb 24 2017