New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695690 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 571533



Sign in to add a comment

Cocoa Page Info: support changing permissions without clobbering UI elements

Project Member Reported by lgar...@chromium.org, Feb 24 2017

Issue description

Right now, Cocoa redraws all permissions after you change them.

This doesn't matter if you use a mouse, but if you use the keyboard it removes focus and creates a new permission list that is not in the accessibility tree.
 
Blocking: 571533
Cc: patricia...@chromium.org lpalmaro@chromium.org leberly@chromium.org maxwalker@chromium.org emilyschechter@chromium.org
 Issue 772111  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b8d28d3b852d8e881082efc3c08bde3077b416

commit 07b8d28d3b852d8e881082efc3c08bde3077b416
Author: Patricia Lor <patricialor@chromium.org>
Date: Fri Oct 13 00:46:36 2017

Desktop Page Info/Mac: Don't immediately remove permissions set back to default.

Using Page Info to update permissions back to the factory default setting on Mac
will immediately remove them from the bubble. This might be annoying since users
may not expect this and may have mistakenly selected the wrong setting, in which
case they would have to open Site Details to change it again (or wait for
another prompt).

Match the behaviour on Views and don't remove the permission until the Page Info
bubble has been closed.

Manual test - On Mac, Navigate to https://permission.site. Click "Notifications"
button and click "Block" when the prompt shows up. Then click "USB", select a
device and click "Connect" (USB devices can be added manually at
chrome://usb-internals/). Open the Page Info bubble by clicking the icon to the
left of the Omnibox. Verify it has an entry for "Notifications" and the name of
the USB device chosen earlier. Change the "Notifications" entry to
"Ask (default)", and verify it does not disappear and the USB entry is still
there, and that pressing tab will cycle through all the focusable elements in
Page Info. Then click the "x" next to the USB device and verify it disappears.
Verify pressing tab to cycle through all the focusable elements in Page Info
still works.

Bug:  772769 ,  695690 ,  696859 
Change-Id: I3cf61b6598dd4deceb4d87f79f31e3541507dcda
Reviewed-on: https://chromium-review.googlesource.com/706446
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508570}
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/permission_selector_button.h
[modify] https://crrev.com/07b8d28d3b852d8e881082efc3c08bde3077b416/chrome/browser/ui/cocoa/page_info/permission_selector_button.mm

Cc: raymes@chromium.org
 Issue 772769  has been merged into this issue.
Status: Fixed (was: Available)

Sign in to add a comment