Note sure if this indicates the test needs to be updated for mash, or a more fundamental problem.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f Author: sky <sky@chromium.org> Date: Mon Feb 27 19:07:06 2017 chromeos: makes more tests run in both mash and ash BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 TEST=test only changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2718763003 Cr-Commit-Position: refs/heads/master@{#453280} [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
Some of these fail from the lack of a ShelfBezelEventHandler; See issue 631216 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3 commit 1de4bccb0ea32f5c5bd82d7d48553c11f88659a3 Author: Mike Wasserman <msw@chromium.org> Date: Thu Oct 19 01:24:16 2017 mash: Fix and enable AppListButton unit test. The app list button test should start drags on the app list button. It was actually targetting the ShelfBezelEventHandler. Fix and enable the test, make other cleanup changes. Enable ShelfLayoutManager test fixtures that work as-is in mash. Move remaining ShelfLayoutManager test failures to filter file. Bug: 695686 , 775177 Change-Id: I7638c6294bc8ce6e2c6b91d459d462a5b357db5d Reviewed-on: https://chromium-review.googlesource.com/723863 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509959} [modify] https://crrev.com/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3/ash/shelf/app_list_button_unittest.cc [modify] https://crrev.com/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3/testing/buildbot/filters/ash_unittests_mash.filter
It seems like this is fixed now: $ grep 'ShelfLayout' testing/buildbot/filters/* $ grep MASH ash/shelf/shelf_layout_manager_unittest.cc $ Please feel free to reopen with details on which tests are still disabled. Thanks!
Comment 1 by bugdroid1@chromium.org
, Feb 27 2017