New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695675 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

modules.dep in ChromeOS may not be up to date

Project Member Reported by edjee@google.com, Feb 23 2017

Issue description

In a base image of ChromeOS, /lib/modules/.../modules.dep contains information about test_modules.ko and test_nx.ko, while such kernel module files do not exist in the image.

Also, when building a test image, if any test package runs "depmod" (because, for example, it installs any out-of-tree kernel modules), modules.dep loses the information about test_*.ko, while test_*.ko files exist in the image.
 

Comment 1 by edjee@google.com, Feb 23 2017

Description: Show this description

Comment 2 by edjee@google.com, Feb 23 2017

Owner: edjee@google.com
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/53542e700d07f869b8851715e8a637fd80eec9d0

commit 53542e700d07f869b8851715e8a637fd80eec9d0
Author: Edward Hyunkoo Jee <edjee@google.com>
Date: Tue Mar 14 05:40:01 2017

run "depmod" after emerging all the packages

BUG= chromium:695675 

TEST=Build a base image and a test image of any board. Verify that
  (1) the base image's /lib/modules/.../modules.dep does not contain
      information about test_*.ko, and
  (2) the test image's /lib/modules/.../modules.dep contains
      information about test_*.ko.

Change-Id: I45346f0fa9f1b7bdb85fb735a87b5bc50837cdcb
Reviewed-on: https://chromium-review.googlesource.com/446687
Commit-Ready: Edward Jee <edjee@google.com>
Tested-by: Edward Jee <edjee@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/53542e700d07f869b8851715e8a637fd80eec9d0/build_library/build_image_util.sh
[modify] https://crrev.com/53542e700d07f869b8851715e8a637fd80eec9d0/build_library/test_image_util.sh
[modify] https://crrev.com/53542e700d07f869b8851715e8a637fd80eec9d0/build_library/base_image_util.sh
[modify] https://crrev.com/53542e700d07f869b8851715e8a637fd80eec9d0/build_library/dev_image_util.sh

Comment 4 by edjee@google.com, Mar 14 2017

Status: Fixed (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/a979a90a779caa1c3c882a747b85c2f851f0af20

commit a979a90a779caa1c3c882a747b85c2f851f0af20
Author: Edward Hyunkoo Jee <edjee@google.com>
Date: Wed Mar 15 00:09:56 2017

update_kernel.sh: run "depmod" after copying kernel modules

BUG= chromium:695675 

TEST=Tested with the following steps.
  (workstation) $ cros_sdk
  (cr) $ ./setup_board --board=lakitu --default && ./build_packages && ./build_image --noenable_rootfs_verification --disk_layout=base test
  (workstation) $ kvm -m 1024 -nographic -net nic,model=virtio -net user,hostfwd=tcp:127.0.0.1:9222-:22 -hda src/build/images/lakitu/latest/chromiumos_test_image.bin
  (vm) # cd /lib/modules/4.4.44+
  (vm) # ls -al  # Check the date and size of modules.dep and other files.
  (cr) $ ./update_kernel.sh --remote=localhost --ssh_port=9222 --private_key=../build/images/lakitu/latest/id_rsa
  (vm) # ls -al  # Check the date and size of modules.dep and other files.
  Compared the two "ls -al" results on the VM. And verified modules.dep and other files were updated after running update_kernel.sh.

Change-Id: Ifa542d544ea9b5948e2c9c6f382ca1ade6c1e421
Reviewed-on: https://chromium-review.googlesource.com/451798
Commit-Ready: Edward Jee <edjee@google.com>
Tested-by: Edward Jee <edjee@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/a979a90a779caa1c3c882a747b85c2f851f0af20/update_kernel.sh

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a1e0da70dcea4e0f28e85cda038b876b9ec958e9

commit a1e0da70dcea4e0f28e85cda038b876b9ec958e9
Author: Edward Hyunkoo Jee <edjee@google.com>
Date: Wed Mar 15 00:09:56 2017

cros-kernel2: remove the outputs of "depmod"

Since CL:446687, "build_image" script will run "depmod". So kernel
packages should not own the outputs of "depmod".

BUG= chromium:695675 
TEST=See CL:446687
CQ-DEPEND=CL:446687,CL:451798

Change-Id: I3909503599f9af0e95a02613fb43384c6badc270
Reviewed-on: https://chromium-review.googlesource.com/446890
Commit-Ready: Edward Jee <edjee@google.com>
Tested-by: Edward Jee <edjee@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/a1e0da70dcea4e0f28e85cda038b876b9ec958e9/eclass/cros-kernel2.eclass

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a9fc48daf46ed9e3dbb79d1736308af83f297dc4

commit a9fc48daf46ed9e3dbb79d1736308af83f297dc4
Author: Stephen Barber <smbarber@chromium.org>
Date: Wed Mar 15 22:02:27 2017

Revert "cros-kernel2: remove the outputs of "depmod""

This reverts commit a1e0da70dcea4e0f28e85cda038b876b9ec958e9.

Reason for revert:  http://crbug.com/701693 

Original change's description:
> cros-kernel2: remove the outputs of "depmod"
> 
> Since CL:446687, "build_image" script will run "depmod". So kernel
> packages should not own the outputs of "depmod".
> 
> BUG= chromium:695675 
> TEST=See CL:446687
> CQ-DEPEND=CL:446687,CL:451798
> 
> Change-Id: I3909503599f9af0e95a02613fb43384c6badc270
> Reviewed-on: https://chromium-review.googlesource.com/446890
> Commit-Ready: Edward Jee <edjee@google.com>
> Tested-by: Edward Jee <edjee@google.com>
> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
> 

TBR=vapier@chromium.org,keescook@chromium.org,edjee@google.com,chirantan@chromium.org,andreyu@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:695675 , chromium:701693 

Change-Id: I88c8832b9232a1d73dbe0f729b62053dd0213881
Reviewed-on: https://chromium-review.googlesource.com/455341
Commit-Queue: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/a9fc48daf46ed9e3dbb79d1736308af83f297dc4/eclass/cros-kernel2.eclass

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment