New issue
Advanced search Search tips

Issue 695665 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

swarmbucket: point to milo by default

Project Member Reported by no...@chromium.org, Feb 23 2017

Issue description

configure default milo instance per buildbucket instance
if url_template is not specified in swarmbucket config, point to the default milo

later, perhaps remove url_template from swarmbucket config, so it is not possible to cross CIA-domains
 

Comment 1 by estaab@chromium.org, Feb 24 2017

Components: Infra>Platform>Buildbucket

Comment 2 by no...@chromium.org, Feb 24 2017

Components: -Infra>Platform>Buildbucket Infra>Platform>Buildbucket>Swarmbucket

Comment 3 by no...@chromium.org, Jun 9 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d

commit 84ea6ef57934e2ef0fec49d6bf5d2f482d18846d
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Aug 29 19:34:22 2017

buildbucket: add global settings

add global settings for default swarming hostname and milo hostname.
Also make default canary percentage configurable.

R=vadimsh@chromium.org
BUG= 695665 

Change-Id: Icc0f942aef9f71c267b1f38953d7686c8d1539ff
Reviewed-on: https://chromium-review.googlesource.com/528666
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/proto/project_config.proto
[add] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/proto/service_config_pb2.py
[add] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/proto/service_config.proto
[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/swarming/swarmbucket_api.py
[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/swarming/swarmingcfg.py
[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/config.py
[modify] https://crrev.com/84ea6ef57934e2ef0fec49d6bf5d2f482d18846d/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ce6eaeb69ec398b4496116dc0f033a4db193144d

commit ce6eaeb69ec398b4496116dc0f033a4db193144d
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Aug 29 22:27:14 2017

buildbucket: specify swarming server in milo URLs

When generating a Milo URL, specify the server parameter (swarming hostname)
in case it is different from the Milo's default.

It does not look great, but it won't be needed when Milo uses buildbucket build
ids instead of swarming task ids.

R=hinoka@chromium.org
BUG= 695665 

Change-Id: I4fb70d441a205792e9a41bf830c26ae819be2b6a
Reviewed-on: https://chromium-review.googlesource.com/642360
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/ce6eaeb69ec398b4496116dc0f033a4db193144d/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/ce6eaeb69ec398b4496116dc0f033a4db193144d/appengine/cr-buildbucket/swarming/test/swarming_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5afb43fc9be3f96bfd0d176401519c3980e682aa

commit 5afb43fc9be3f96bfd0d176401519c3980e682aa
Author: Nodir Turakulov <nodir@chromium.org>
Date: Thu Aug 31 21:07:39 2017

remove swarming and milo hostnames

url_format field was deprecated. It is ignored, buildbucket server decides
which URL to use.

Remove swarming hostname because it matches cr-buildbucket-dev's default.

R=hinoka@chromium.org

Bug:  695665 
Change-Id: I7f21eacf324208850af108eb463492063de6a3f5
No-Try: True
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/641855
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/5afb43fc9be3f96bfd0d176401519c3980e682aa/cr-buildbucket-dev.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/65d4ee9d06204046ea4d338d50453f17768ac79c

commit 65d4ee9d06204046ea4d338d50453f17768ac79c
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 01 22:18:07 2017

Comment 8 by no...@chromium.org, Dec 2 2017

Status: Fixed (was: Started)

Sign in to add a comment