New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695662 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 707815


Show other hotlists

Hotlists containing this issue:
Chrome-Intents


Sign in to add a comment

SVGImageElement should be a canvas image source

Project Member Reported by junov@chromium.org, Feb 23 2017

Issue description

Spec: https://html.spec.whatwg.org/multipage/scripting.html#image-sources-for-2d-rendering-contexts:htmlorsvgimageelement

SVGImageElement needs to be added to the CanvasImageSource union typedef.


 

Comment 1 by junov@chromium.org, Feb 23 2017

Cc: chrishtr@chromium.org
Labels: -Type-Launch-OWP Type-Feature
This is a very minor feature. Not sure it warrants going through the formal launch process.

@chrishtr: WDYT?
I think this should go through an intent, even though it's small. It's
important for visibility and documentation of changes, for the benefit of not
just us but the community of developers.

Comment 3 by junov@chromium.org, Feb 27 2017

@fserb:
The launch process is this: https://www.chromium.org/blink/launching-features

Also, you will need to discover the magic of our bindings code generator: https://www.chromium.org/blink/webidl

Comment 4 by junov@chromium.org, Mar 1 2017

Labels: OWP-Standards-OfficialSpec OWP-Design-No OWP-Type-ChangeAPI
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a275c5522ae4dbf8e3dee5c7246e74141b5142

commit 11a275c5522ae4dbf8e3dee5c7246e74141b5142
Author: fserb <fserb@chromium.org>
Date: Fri Mar 24 00:04:09 2017

Adds SVGImageElement to CanvasImageSource

Relevant spec: https://html.spec.whatwg.org/multipage/scripting.html#image-sources-for-2d-rendering-contexts:htmlorsvgimageelement

SVGImageElement should be part of CanvasImageSource union typedef, i.e., be allowed as an source for drawImage(). This CL does that, while creating a common interface for both HTMLImageElement and SVGImageElement.

BUG= 695662 

Review-Url: https://codereview.chromium.org/2723093004
Cr-Commit-Position: refs/heads/master@{#459289}

[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.pattern.image.string-expected.txt
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.pattern.image.undefined-expected.txt
[add] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-svg-expected.html
[add] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-svg.html
[add] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/LayoutTests/fast/canvas/resources/rect.svg
[add] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/LayoutTests/http/tests/security/canvas-remote-read-remote-svg-image.html
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/html/HTMLImageElement.h
[add] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/html/canvas/CanvasImageElementSource.cpp
[add] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/html/canvas/CanvasImageElementSource.h
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/svg/SVGImageElement.cpp
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/core/svg/SVGImageElement.h
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/11a275c5522ae4dbf8e3dee5c7246e74141b5142/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl

Comment 6 by fs...@chromium.org, Apr 3 2017

Blocking: 707815

Comment 7 by fs...@chromium.org, Apr 3 2017

This is done. Moving forward to ImageBitmapSource now.

Comment 8 by fs...@chromium.org, Apr 3 2017

Status: Fixed (was: Assigned)

Sign in to add a comment