New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695654 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 688460



Sign in to add a comment

Component updater is downloading older version of Flash

Project Member Reported by kerrnel@chromium.org, Feb 23 2017

Issue description

Note: this probably explains a lot of the confusing update notifications users have received

The component updater on Chrome OS believes it has Flash version 0.0.0.0, since it does not know about the command line Flash, and is downloading an older version of Flash and prompting the user to reboot and apply the update. Chrome does not actually load the older version of Flash, however this is extremely annoying and confusing behavior for our users. 

 

Comment 1 by vsu...@chromium.org, Feb 24 2017

Cc: hsiangc@chromium.org

Comment 2 by ihf@chromium.org, Feb 24 2017

Blocking: 688460
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/421c3a3a8e73cf590f69624b15e8187a0ec413ba

commit 421c3a3a8e73cf590f69624b15e8187a0ec413ba
Author: kerrnel <kerrnel@chromium.org>
Date: Fri Feb 24 21:15:47 2017

Report built_in_version to Omaha for Flash updates.

Report the built in Flash version to Omaha server for Flash updates, to
prevent a stale component update from being delivered.

BUG= 695654 

Review-Url: https://codereview.chromium.org/2711593006
Cr-Commit-Position: refs/heads/master@{#452919}

[modify] https://crrev.com/421c3a3a8e73cf590f69624b15e8187a0ec413ba/chrome/browser/component_updater/pepper_flash_component_installer.cc

Labels: Merge-Request-57
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 27 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af24db32f4d38bbd8e85092129506dcc9ebc9bfc

commit af24db32f4d38bbd8e85092129506dcc9ebc9bfc
Author: Greg Kerr <kerrnel@chromium.org>
Date: Tue Feb 28 02:03:34 2017

Report built_in_version to Omaha for Flash updates.

Report the built in Flash version to Omaha server for Flash updates, to
prevent a stale component update from being delivered.

BUG= 695654 

Review-Url: https://codereview.chromium.org/2711593006
Cr-Commit-Position: refs/heads/master@{#452919}
(cherry picked from commit 421c3a3a8e73cf590f69624b15e8187a0ec413ba)

Review-Url: https://codereview.chromium.org/2724523002 .
Cr-Commit-Position: refs/branch-heads/2987@{#711}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/af24db32f4d38bbd8e85092129506dcc9ebc9bfc/chrome/browser/component_updater/pepper_flash_component_installer.cc

This change landed in 57.0.2987.86, which has not been picked up by an M57 beta yet. Once 57.0.2987.88 is picked up, we will see the yellow icon downgrade as well.
Status: Verified (was: Started)

Sign in to add a comment