New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695647 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
waff...@chromium.org
mevissen@chromium.org
█ rpop@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

remove links to tools.google.com/chrome from code

Project Member Reported by wfh@chromium.org, Feb 23 2017 
http://tools.google.com/chrome/[a]/[b]

does a redirect to

https://www.google.com/[a]/chrome/browser/[b]

we should remove these links from the Chromium codebase and update them all to the new format on google.com/chrome instead of relying on this redirect.

Comment 1 by wfh@chromium.org, Feb 23 2017

Cc: waff...@chromium.org mevissen@chromium.org rpop@chromium.org
URLs found so far:

IDS_WELCOME_PAGE_URL - http://tools.google.com/chrome/intl/[GRITLANGCODE]/welcome.html

Also seeing requests to http://tools.google.com/chrome/intl/en/themes/index.html but not sure yet where these are coming from

Comment 2 by wfh@chromium.org, Feb 23 2017 

c.f. internal b/35713775

Comment 3 by mevissen@chromium.org, Feb 24 2017

Labels: Postmortem-Followup
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/896dcfde5fc56946c1fc84931d9bfdf6b627241f

commit 896dcfde5fc56946c1fc84931d9bfdf6b627241f
Author: wfh <wfh@chromium.org>
Date: Tue Feb 28 05:14:56 2017

Update welcome page URL to new format.

BUG= 695647 
TEST=install Chrome, verify welcome page loads correctly.

Review-Url: https://codereview.chromium.org/2710333002
Cr-Commit-Position: refs/heads/master@{#453511}

[modify] https://crrev.com/896dcfde5fc56946c1fc84931d9bfdf6b627241f/chrome/app/resources/locale_settings.grd

Comment 5 by wfh@chromium.org, Feb 28 2017

Labels: Merge-Request-57
request merge for 896dcfde5fc56946c1fc84931d9bfdf6b627241f to M57

Comment 6 by wfh@chromium.org, Feb 28 2017 

this CL does not require localization so should be safe to merge into M57

Comment 7 by gov...@chromium.org, Feb 28 2017

Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on comment #6. Please merge ASAP. Thank you.

Comment 8 by wfh@chromium.org, Feb 28 2017

Labels: M-57 ReleaseBlock-Stable
will merge after Canary coverage.

Comment 9 by gov...@chromium.org, Feb 28 2017 

Sure, please merge after Canary coverage. 
Also pls apply appropriate os label. Thank you.

Comment 10 by wfh@google.com, Mar 1 2017

Labels: OS-Windows

Comment 11 by wfh@chromium.org, Mar 1 2017 

Verified this new code works with 58.0.3027.0 by sinkholing tools.google.com and installing Chrome and the welcome page works.

I'll now merge this to M57 now.

Comment 12 by wfh@chromium.org, Mar 1 2017

Components: UI>Browser>FirstRun
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 1 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d4a40dc0f0876f4717341c1f5b75a4af6a2d084

commit 3d4a40dc0f0876f4717341c1f5b75a4af6a2d084
Author: Will Harris <wfh@chromium.org>
Date: Wed Mar 01 21:56:13 2017

Merge M57: Update welcome page URL to new format.

BUG= 695647 
TEST=install Chrome, verify welcome page loads correctly.

Review-Url: https://codereview.chromium.org/2710333002
Cr-Commit-Position: refs/heads/master@{#453511}
(cherry picked from commit 896dcfde5fc56946c1fc84931d9bfdf6b627241f)

Review-Url: https://codereview.chromium.org/2725973002 .
Cr-Commit-Position: refs/branch-heads/2987@{#732}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/3d4a40dc0f0876f4717341c1f5b75a4af6a2d084/chrome/app/resources/locale_settings.grd

Comment 14 by wfh@chromium.org, Mar 1 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment