precq misses deqp build failure on boards with USE=vulkan |
||||||
Issue descriptionThe only boards that I know of with USE=vulkan enabled by default are apollolake and skylake devices. Adding a representative board from either chipset would have caught the build failure that ended up choking the CQ.
,
Feb 23 2017
What's the best representative board for this?
,
Feb 23 2017
How about caroline?
,
Feb 23 2017
caroline should be good.
,
Feb 24 2017
Here is the current default set by the way:
# The default list of pre-cq configs to use.
PRE_CQ_DEFAULT_CONFIGS = [
'daisy_spring-no-vmtest-pre-cq', # kernel 3.8 coverage
'lumpy-no-vmtest-pre-cq', # kernel 3.8 coverage
'rambi-pre-cq', # vmtest coverage
'samus-no-vmtest-pre-cq', # kernel 3.14 coverage
'whirlwind-no-vmtest-pre-cq', # brillo coverage
'x86-alex-no-vmtest-pre-cq', # x86 coverage
]
ihf are you suggesting swapping out rambi-pre-cq? or just adding caroline?
If simply adding, I'd rather add caroline-no-vmtest-pre-cq; non-vmtest builders are cheap, vmtest ones are not (yet).
(from chromite/lib/constants.py)
,
Feb 24 2017
Ok, lets swap out but keep rambi as non-vmtest (to not get surprises, and it is a pretty popular config): +caroline-pre-cq -rambi-pre-cq +rambi-no-vmtest-pre-cq
,
Feb 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c12f26a7636ee4e5775cd920a019e2c327d5e4e2 commit c12f26a7636ee4e5775cd920a019e2c327d5e4e2 Author: Aviv Keshet <akeshet@chromium.org> Date: Sat Feb 25 18:32:08 2017 pre-cq: update default pre-cq; add caroline-pre-cq, demote rambi Swap in caroline for vmtest instead of rambi. Preserve rambi as non-vmtest. BUG= chromium:695638 TEST=caroline-pre-cq tryjob Change-Id: I786304bc57768ad060655752a0a769d557d68018 Reviewed-on: https://chromium-review.googlesource.com/446586 Commit-Ready: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/c12f26a7636ee4e5775cd920a019e2c327d5e4e2/lib/constants.py
,
Mar 7 2017
This looks done, assigning to Aviv to close if true
,
Mar 8 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ihf@chromium.org
, Feb 23 2017