New issue
Advanced search Search tips

Issue 695632 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 693114



Sign in to add a comment

RootWindowControllerTest.MoveWindows_Basic triggers shutdown crash in mash

Project Member Reported by sky@chromium.org, Feb 23 2017

Issue description

This test triggers a shutdown crash in mash:

#0  0x00007ffff279bde3 in wm::FocusController::SetFocusedWindow (this=0x8da611a4020, window=0x0) at ../../ui/wm/core/focus_controller.cc:256
#1  0x00007ffff279b7ba in wm::FocusController::FocusAndActivateWindow (this=0x8da611a4020, reason=aura::client::ActivationChangeObserver::ActivationReason::ACTIVAT\
ION_CLIENT, window=0x0) at ../../ui/wm/core/focus_controller.cc:220
#2  0x00007ffff279b461 in wm::FocusController::FocusWindow (this=0x8da611a4020, window=0x0) at ../../ui/wm/core/focus_controller.cc:105
#3  0x00007ffff61966f1 in ash::Shell::~Shell (this=0x8da61047320) at ../../ash/shell.cc:428
#4  0x00007ffff6197a39 in ash::Shell::~Shell (this=0x8da61047320) at ../../ash/shell.cc:415
#5  0x00007ffff6194a1d in ash::Shell::DeleteInstance () at ../../ash/shell.cc:213
#6  0x000000000072c641 in ash::mus::WindowManager::Shutdown (this=0x8da611eac20) at ../../ash/mus/window_manager.cc:256
#7  0x000000000072c4b5 in ash::mus::WindowManager::~WindowManager (this=0x8da611eac20) at ../../ash/mus/window_manager.cc:80
#8  0x000000000072c6d9 in ash::mus::WindowManager::~WindowManager (this=0x8da611eac20) at ../../ash/mus/window_manager.cc:79
#9  0x00000000005c86d2 in std::default_delete<ash::mus::WindowManager>::operator() (this=0x8da611d1968, __ptr=0x8da611eac20) at ../../build/linux/ubuntu_precise_am\
d64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:63
#10 0x00000000005c699c in std::unique_ptr<ash::mus::WindowManager, std::default_delete<ash::mus::WindowManager> >::reset (this=0x8da611d1968, __p=0x8da611eac20) at\
 ../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:245
#11 0x00000000007398e8 in ash::mus::WindowManagerApplication::~WindowManagerApplication (this=0x8da611d18e0) at ../../ash/mus/window_manager_application.cc:44
#12 0x0000000000739a49 in ash::mus::WindowManagerApplication::~WindowManagerApplication (this=0x8da611d18e0) at ../../ash/mus/window_manager_application.cc:41
#13 0x000000000048bbef in std::default_delete<mash::test::TestContextFactory>::operator() (this=0x8da611d24c8, __ptr=0x8da611d18e0) at ../../build/linux/ubuntu_pre\
cise_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:63
#14 0x00000000005c64ec in std::unique_ptr<ash::mus::WindowManagerApplication, std::default_delete<ash::mus::WindowManagerApplication> >::reset (this=0x8da611d24c8,\
 __p=0x8da611d18e0) at ../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:245
#15 0x00000000009b902d in ash::test::AshTestHelper::TearDown (this=0x8da611d2480) at ../../ash/test/ash_test_helper.cc:173
#16 0x00000000009b6bb6 in ash::test::AshTestBase::TearDown (this=0x8da6111af70) at ../../ash/test/ash_test_base.cc:158
#17 0x00000000009f6cbe in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (object=0x8da6111af70, method=&virtual testing::Test::Tear\
Down(), location=0xc39318 "TearDown()") at ../../testing/gtest/src/gtest.cc:2402


I'm tagging this with mustash-1 as shutdown crashes generally indicate bad code that is likely to bite us sooner rather than later. The test does fail though, so it's possible the badness is entirely in the test, but we should understand that.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee93828200a82947abf0d497c4b898b54c9b87d

commit 2ee93828200a82947abf0d497c4b898b54c9b87d
Author: erg <erg@chromium.org>
Date: Wed Mar 01 00:41:48 2017

mash_unittests: Enable RootWindowControllerTest.MoveWindows_Basic.

MoveWindows_Basic tests a lot of functionality all in one test. We don't
have enough of the display management system built to test the details
of display changes, though. So move the one check we can't yet pass
behind an if instead of disabling the entire thing.

BUG= 695632 

Review-Url: https://codereview.chromium.org/2721103002
Cr-Commit-Position: refs/heads/master@{#453775}

[modify] https://crrev.com/2ee93828200a82947abf0d497c4b898b54c9b87d/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/2ee93828200a82947abf0d497c4b898b54c9b87d/ash/test/ash_test_helper.cc

Comment 5 by e...@chromium.org, Mar 2 2017

Labels: -mustash-1
Removing the mustash-1 tag now that this is 90% enabled and verified that this crash wasn't representative of a real crash.

Comment 6 by sky@chromium.org, Mar 7 2017

Blocking: 693114

Comment 7 by sky@chromium.org, Mar 29 2017

Labels: mustash-2
Adding mustash-2 to make sure we evaluate this for mustash-2.

Comment 8 by sky@chromium.org, Jun 21 2017

Owner: sky@chromium.org
Status: Fixed (was: Untriaged)
This was fixed when we switched to simplified display management.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/850f98b75cfef136b453da20c66710e1b643fd9c

commit 850f98b75cfef136b453da20c66710e1b643fd9c
Author: Mike Wasserman <msw@chromium.org>
Date: Tue Oct 17 02:39:31 2017

mash: Enable extra checks in RootWindowControllerTest MoveWindows_Basic

Bug:  695632 
Change-Id: Ie6c22f2d636d4437963039836011453815b964d9
Reviewed-on: https://chromium-review.googlesource.com/721976
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509234}
[modify] https://crrev.com/850f98b75cfef136b453da20c66710e1b643fd9c/ash/root_window_controller_unittest.cc

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment