New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695626 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

White text-shadow darkens background instead of lightening.

Project Member Reported by lgar...@chromium.org, Feb 23 2017

Issue description

Chrome 58.0.3018.3
OSX 10.12.3

What steps will reproduce the problem?
(1) Open the DevTools Security panel

What is the expected result?
The "Main Origin" text-shadow (rgba(255, 255, 255, 0.75) 0 1px 0) is brighter than the background (expected.png).

What happens instead?
The text-shadow is darker than the background (observed.png).

bisect-builds.py pinpoints a Skia roll: https://chromium.googlesource.com/chromium/src/+log/f1965acd5e67a8c7d5b537bb56dbbc5733ba7a67..8eaad28b5cb7f0386f0f38c227dbc359111a3d5b
This first landed in 58.0.3010.0 [1].

I've attached a minimal repro as "text-shadow.html".

[1] https://storage.googleapis.com/chromium-find-releases-static/8ea.html#8eaad28b5cb7f0386f0f38c227dbc359111a3d5b

One commit in that range (https://skia-review.googlesource.com/c/8328/) appears to be due to another edge-aliasing issue: Issue 682918.

jvanverth@: could you triage, or pass it to someone else in the Skia range if it's a different commit?

 
expected.png
32.0 KB View Download
observed.png
22.4 KB View Download
text-shadow.html
163 bytes View Download
Description: Show this description
Description: Show this description
I'm not sure how my change would have caused this -- it's only tweaking the base sizes for the SDF generation and the rendering method isn't different. But I'll take a look.
Cc: bsalomon@chromium.org
Did you find anything?

I'm hesitant to mark this as a blocker, but I don't know how to bisect the Skia roll.

Adding bsalomon@, because https://skia-review.googlesource.com/c/7760/ seems to have something to do with blending and opacity.
Here's a reduced example http://output.jsbin.com/kefizev/quiet.

Note that the opacity of the shadow changes its brightness.

This only impacts text shadows *without* a blur. Applying a 0.001px blur works around the issue.
Sorry, I haven't had a chance to take a look yet. I'll try to do a bisect this morning.
Labels: Needs-Bisect
Cc: -bsalomon@chromium.org
Owner: bsalomon@chromium.org
After bisecting, it does appear to be https://skia-review.googlesource.com/c/7760/. Reassigning.
I believe this and  issue 696966  are likely to be the same. Investigating...
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/afb41033efae3f5c71cac8c6127236efab613125

commit afb41033efae3f5c71cac8c6127236efab613125
Author: Brian Salomon <bsalomon@google.com>
Date: Wed Mar 01 19:41:11 2017

Unpremul the blend constant in PDLCDXferProcessor.

This was accidentally dropped in https://skia.googlesource.com/skia.git/+/eec6f7be5461e588210f383b8af18f324a2bdb46

BUG= chromium:695626 

Change-Id: If715fdc673fafa4baf6a61545c2b3b9d3ded9232
Reviewed-on: https://skia-review.googlesource.com/9117
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/afb41033efae3f5c71cac8c6127236efab613125/src/gpu/effects/GrPorterDuffXferProcessor.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6246fbb36f94bb041f427d1f972cd3fd41dd40ff

commit 6246fbb36f94bb041f427d1f972cd3fd41dd40ff
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Mar 01 21:45:48 2017

Roll src/third_party/skia/ af9847ee1..5ff3a5c13 (8 commits).

https://skia.googlesource.com/skia.git/+log/af9847ee11ae..5ff3a5c13e57

$ git log af9847ee1..5ff3a5c13 --date=short --no-merges --format='%ad %ae %s'
2017-03-01 bsalomon Remove stencil related flags from GrInstancedPipelineInfo.
2017-03-01 reed remove unneeded android flag for textdecorations
2017-03-01 caryclark fix fuzzer
2017-03-01 bsalomon Unpremul the blend constant in PDLCDXferProcessor.
2017-03-01 senorblanco GrTessellator: minor cleanups and speedups.
2017-03-01 herb Use SkArenaAlloc in SkEdgeBuilder.
2017-03-01 brianosman Move GrTextureProvider to src
2017-03-01 brianosman Set window dimensions in raster on Unix

Created with:
  roll-dep src/third_party/skia
BUG= 695626 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2726783003
Cr-Commit-Position: refs/heads/master@{#454046}

[modify] https://crrev.com/6246fbb36f94bb041f427d1f972cd3fd41dd40ff/DEPS

Components: -Blink>CSS
Cc: ranjitkan@chromium.org bsalomon@chromium.org bunge...@chromium.org nyerramilli@chromium.org msrchandra@chromium.org fmalita@chromium.org
 Issue 696966  has been merged into this issue.
Status: Fixed (was: Assigned)
This made it in before Skia cut a branch for M58.

Sign in to add a comment