A placeholder for unified instrumentation.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc9533e11917bced54ea40a842d9b0333bc85b09 commit fc9533e11917bced54ea40a842d9b0333bc85b09 Author: pfeldman <pfeldman@chromium.org> Date: Tue Feb 28 06:09:54 2017 Migrate performance monitor to inspector instrumentation. BUG= 695625 Review-Url: https://codereview.chromium.org/2713553010 Cr-Commit-Position: refs/heads/master@{#453517} [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/frame/PerformanceMonitor.h [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/fc9533e11917bced54ea40a842d9b0333bc85b09/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d8c99cfe73e17fccae5512ef7abf38381370a17 commit 9d8c99cfe73e17fccae5512ef7abf38381370a17 Author: alph <alph@chromium.org> Date: Fri Mar 03 01:45:16 2017 DevTools: Rename InspectorInstrumentation:: namespace into probe:: BUG= 695625 NOTRY=true Review-Url: https://codereview.chromium.org/2727633006 Cr-Commit-Position: refs/heads/master@{#454460} [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/CharacterData.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/ContainerNode.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/MutationObserver.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/PseudoElement.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/StyleEngine.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/events/EventTarget.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/events/GenericEventQueue.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/fileapi/FileReader.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/PerformanceMonitor.h [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/ImageLoader.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/ProgressTracker.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/page/ChromeClient.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/page/CreateWindow.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/paint/FramePainter.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/xml/DocumentXSLT.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/eventsource/EventSource.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/fetch/FetchManager.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/notifications/Notification.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp [modify] https://crrev.com/9d8c99cfe73e17fccae5512ef7abf38381370a17/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca679a17b68dbc0b26a088bc099b8ff918a37e00 commit ca679a17b68dbc0b26a088bc099b8ff918a37e00 Author: pfeldman <pfeldman@chromium.org> Date: Mon Mar 06 23:18:19 2017 DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped probes. BUG= 695625 Review-Url: https://codereview.chromium.org/2732643003 Cr-Commit-Position: refs/heads/master@{#454993} [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/events/EventTarget.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/frame/PerformanceMonitor.h [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/ca679a17b68dbc0b26a088bc099b8ff918a37e00/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/931b43e777872ff7d61803326c52371bc8b035a5 commit 931b43e777872ff7d61803326c52371bc8b035a5 Author: alph <alph@chromium.org> Date: Tue Mar 07 20:23:52 2017 [instrumentation] Introduce InspectorTraceEvents agent Clean the instrumented code up by moving "devtools.timeline" trace events into the agent. BUG= 695625 Review-Url: https://codereview.chromium.org/2729613008 Cr-Commit-Position: refs/heads/master@{#455197} [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/931b43e777872ff7d61803326c52371bc8b035a5/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3c77629c73732f7f34ee31e73983a49a4ccd068 commit d3c77629c73732f7f34ee31e73983a49a4ccd068 Author: pfeldman <pfeldman@chromium.org> Date: Tue Mar 07 23:38:35 2017 DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. BUG= 695625 Review-Url: https://codereview.chromium.org/2733093003 Cr-Commit-Position: refs/heads/master@{#455290} [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/events/EventTarget.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp [modify] https://crrev.com/d3c77629c73732f7f34ee31e73983a49a4ccd068/third_party/WebKit/Source/modules/notifications/Notification.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04 commit 0c1275bf5e9c98c1bcb01cb86be187d10ec54b04 Author: thakis <thakis@chromium.org> Date: Wed Mar 08 15:08:09 2017 Revert of [instrumentation] Introduce InspectorTraceEvents agent (patchset #3 id:40001 of https://codereview.chromium.org/2729613008/ ) Reason for revert: Speculative; looks like this broke component builds for a bunch of people and bots, https://crbug.com/699477 Original issue's description: > [instrumentation] Introduce InspectorTraceEvents agent > > Clean the instrumented code up by moving "devtools.timeline" trace events into the agent. > > BUG= 695625 > > Review-Url: https://codereview.chromium.org/2729613008 > Cr-Commit-Position: refs/heads/master@{#455197} > Committed: https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52371bc8b035a5 TBR=pfeldman@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 695625 Review-Url: https://codereview.chromium.org/2737623006 Cr-Commit-Position: refs/heads/master@{#455452} [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/0c1275bf5e9c98c1bcb01cb86be187d10ec54b04/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac0269296fe6f43e9e15b4b56e2a7ab47156e573 commit ac0269296fe6f43e9e15b4b56e2a7ab47156e573 Author: alph <alph@chromium.org> Date: Wed Mar 08 22:10:31 2017 [instrumentation] Introduce InspectorTraceEvents agent Clean the instrumented code up by moving "devtools.timeline" trace events into the agent. BUG= 695625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_clang_dbg;master.tryserver.chromium.win:win_clang_x64_dbg Review-Url: https://codereview.chromium.org/2729613008 Cr-Original-Commit-Position: refs/heads/master@{#455197} Committed: https://chromium.googlesource.com/chromium/src/+/931b43e777872ff7d61803326c52371bc8b035a5 Review-Url: https://codereview.chromium.org/2729613008 Cr-Commit-Position: refs/heads/master@{#455554} [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/ac0269296fe6f43e9e15b4b56e2a7ab47156e573/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87cb93767256f83a39625de66e528ef2fb1296d5 commit 87cb93767256f83a39625de66e528ef2fb1296d5 Author: pfeldman <pfeldman@chromium.org> Date: Thu Mar 09 00:35:22 2017 DevTools: move counter-related devtools.timeline trace events into probe:: probes. BUG= 695625 Review-Url: https://codereview.chromium.org/2737863002 Cr-Commit-Position: refs/heads/master@{#455613} [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/events/EventDispatcher.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp [modify] https://crrev.com/87cb93767256f83a39625de66e528ef2fb1296d5/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf59a89caec7659dae0a166d61185f7b6cfb0bf0 commit cf59a89caec7659dae0a166d61185f7b6cfb0bf0 Author: alph <alph@chromium.org> Date: Thu Mar 16 02:27:37 2017 [instrumentation] Generate instrumentation probes with jinja2 BUG= 695625 Review-Url: https://codereview.chromium.org/2748383002 Cr-Commit-Position: refs/heads/master@{#457321} [modify] https://crrev.com/cf59a89caec7659dae0a166d61185f7b6cfb0bf0/third_party/WebKit/Source/core/inspector/BUILD.gn [delete] https://crrev.com/8db424fb7191b2be7b58b89427b9b258d057d97b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py [add] https://crrev.com/cf59a89caec7659dae0a166d61185f7b6cfb0bf0/third_party/WebKit/Source/core/inspector/InstrumentingAgents_h.template [rename] https://crrev.com/cf59a89caec7659dae0a166d61185f7b6cfb0bf0/third_party/WebKit/Source/core/inspector/InstrumentingProbes.idl [add] https://crrev.com/cf59a89caec7659dae0a166d61185f7b6cfb0bf0/third_party/WebKit/Source/core/inspector/InstrumentingProbesCodeGenerator.py [add] https://crrev.com/cf59a89caec7659dae0a166d61185f7b6cfb0bf0/third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template [add] https://crrev.com/cf59a89caec7659dae0a166d61185f7b6cfb0bf0/third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_h.template
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3 commit d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3 Author: pfeldman <pfeldman@chromium.org> Date: Mon Mar 20 21:05:42 2017 DevTools: migrate remaining parse html probe to probes. BUG= 695625 Review-Url: https://codereview.chromium.org/2753183002 Cr-Commit-Position: refs/heads/master@{#458180} [modify] https://crrev.com/d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp [modify] https://crrev.com/d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480ae9f27c791955a96bbdb7b9db090ec57db4ab commit 480ae9f27c791955a96bbdb7b9db090ec57db4ab Author: alph <alph@chromium.org> Date: Thu Mar 23 19:42:37 2017 [instrumentation] Generalize instrumentation to be used beyond the core layer Changes made in the patch: - Code generator is made more generic, so it can generate code for core as well as for platform. - Introduced instrumenting agents for FetchContext in the platform - Introduced PlatformTraceEventsAgent what listens to PlatformSendRequest probe and produces corresponsing trace events. BUG= 695625 Review-Url: https://codereview.chromium.org/2760363002 Cr-Commit-Position: refs/heads/master@{#459183} [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [rename] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorSession.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorSession.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/c2637be18c2e52da142d6cbf646ab82045e13218/third_party/WebKit/Source/platform/PlatformInstrumentation.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/graphics/Image.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp [rename] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/InstrumentingAgents_h.template [rename] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py [rename] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesImpl_cpp.template [rename] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesImpl_h.template [rename] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/PlatformInstrumentation.cpp [add] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/PlatformInstrumentation.h [add] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/PlatformInstrumentation.idl [add] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/PlatformTraceEventsAgent.cpp [add] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/instrumentation/PlatformTraceEventsAgent.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/480ae9f27c791955a96bbdb7b9db090ec57db4ab/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
Hree's a link to design doc. https://docs.google.com/document/d/1t4nsAhDERh8h7yy5tgJsBLotpmDpYU46JO1Gu8qVoTE/edit# It is still in the draft state and being updated.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80b97517ddcc63d3d901bd63c8184ccd26ac223a commit 80b97517ddcc63d3d901bd63c8184ccd26ac223a Author: alph <alph@chromium.org> Date: Wed Mar 29 05:20:13 2017 [instrumentation] Rename InspectorInstrumentation into CoreProbes Rename probe::InstrumentingAgents into probe::Sink Move probe instrumentation related files to core/probe. BUG= 695625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2772613002 Cr-Commit-Position: refs/heads/master@{#460285} [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/CharacterData.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/ContainerNode.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/MutationObserver.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/PseudoElement.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/StyleEngine.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/events/EventTarget.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/events/GenericEventQueue.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/fileapi/FileReader.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/DOMTimer.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/DOMWindow.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/Frame.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/Screen.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [delete] https://crrev.com/1ade7ad316d84cfceaf7980c4d14bd79aaea0ebc/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h [delete] https://crrev.com/1ade7ad316d84cfceaf7980c4d14bd79aaea0ebc/third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorSession.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/ImageLoader.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/ProgressTracker.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/page/ChromeClient.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/page/CreateWindow.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/paint/FramePainter.cpp [add] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/probe/BUILD.gn [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/probe/CoreProbes.cpp [add] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/probe/CoreProbes.h [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/probe/CoreProbes.pidl [add] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/probe/OWNERS [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/SharedWorker.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/xml/DocumentXSLT.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/eventsource/EventSource.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/notifications/Notification.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/instrumentation/PlatformInstrumentation.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/InstrumentingProbesCodeGenerator.py [add] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/OWNERS [add] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/PlatformProbes.cpp [add] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/PlatformProbes.h [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/PlatformProbes.pidl [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/PlatformTraceEventsAgent.cpp [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/PlatformTraceEventsAgent.h [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/templates/InstrumentingProbesImpl.cpp.tmpl [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/templates/InstrumentingProbesInl.h.tmpl [rename] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/platform/probe/templates/ProbeSink.h.tmpl [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/80b97517ddcc63d3d901bd63c8184ccd26ac223a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a commit 4ed0890b65a8e6b9176085c97bdd2cc8efeff66a Author: alph <alph@chromium.org> Date: Wed Apr 05 00:59:52 2017 [instrumentation] Introduce JSON5 config files for probe generator. BUG= 695625 Review-Url: https://codereview.chromium.org/2790973002 Cr-Commit-Position: refs/heads/master@{#461926} [rename] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py [rename] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl [rename] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl [rename] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/build/scripts/templates/ProbeSink.h.tmpl [modify] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/core/probe/BUILD.gn [modify] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/core/probe/CoreProbes.h [add] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/core/probe/CoreProbes.json5 [modify] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/core/probe/CoreProbes.pidl [modify] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/platform/probe/PlatformProbes.h [add] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/platform/probe/PlatformProbes.json5 [modify] https://crrev.com/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a/third_party/WebKit/Source/platform/probe/PlatformProbes.pidl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e4a897f7551cf7c603cb9ad1fbf534da856c91 commit 68e4a897f7551cf7c603cb9ad1fbf534da856c91 Author: alph <alph@chromium.org> Date: Wed Apr 05 08:52:04 2017 [instrumentation]: Move probe subscriptions to JSON5 config file from PIDL. BUG= 695625 Review-Url: https://codereview.chromium.org/2798453002 Cr-Commit-Position: refs/heads/master@{#462012} [modify] https://crrev.com/68e4a897f7551cf7c603cb9ad1fbf534da856c91/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/68e4a897f7551cf7c603cb9ad1fbf534da856c91/third_party/WebKit/Source/core/probe/CoreProbes.json5 [modify] https://crrev.com/68e4a897f7551cf7c603cb9ad1fbf534da856c91/third_party/WebKit/Source/core/probe/CoreProbes.pidl [modify] https://crrev.com/68e4a897f7551cf7c603cb9ad1fbf534da856c91/third_party/WebKit/Source/platform/probe/PlatformProbes.json5 [modify] https://crrev.com/68e4a897f7551cf7c603cb9ad1fbf534da856c91/third_party/WebKit/Source/platform/probe/PlatformProbes.pidl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebef20203ecdd7fb17431298e175bc15546dc3ee commit ebef20203ecdd7fb17431298e175bc15546dc3ee Author: alph <alph@chromium.org> Date: Wed Apr 05 20:43:56 2017 [instrumentation] Move "include" section from PIDL to JSON5 config BUG= 695625 Review-Url: https://codereview.chromium.org/2793423002 Cr-Commit-Position: refs/heads/master@{#462207} [modify] https://crrev.com/ebef20203ecdd7fb17431298e175bc15546dc3ee/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/ebef20203ecdd7fb17431298e175bc15546dc3ee/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl [modify] https://crrev.com/ebef20203ecdd7fb17431298e175bc15546dc3ee/third_party/WebKit/Source/core/probe/CoreProbes.json5 [modify] https://crrev.com/ebef20203ecdd7fb17431298e175bc15546dc3ee/third_party/WebKit/Source/core/probe/CoreProbes.pidl [modify] https://crrev.com/ebef20203ecdd7fb17431298e175bc15546dc3ee/third_party/WebKit/Source/platform/probe/PlatformProbes.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66d34a387594b54f3fb22a30cb0fd57ff972a002 commit 66d34a387594b54f3fb22a30cb0fd57ff972a002 Author: alph <alph@chromium.org> Date: Thu Apr 06 00:09:33 2017 [instrumentation] Turn inspector override "probes" return values into output parameters. This is a temporary measure. They should eventually become regular functions. BUG= 695625 Review-Url: https://codereview.chromium.org/2800853002 Cr-Commit-Position: refs/heads/master@{#462286} [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/probe/CoreProbes.h [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/probe/CoreProbes.pidl [modify] https://crrev.com/66d34a387594b54f3fb22a30cb0fd57ff972a002/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08edaf185f52af495778ce04d7f28c781031dc66 commit 08edaf185f52af495778ce04d7f28c781031dc66 Author: tasak <tasak@google.com> Date: Thu Apr 06 02:22:51 2017 Revert of [instrumentation] Turn inspector override "probes" return values into output parameters. (patchset #2 id:20001 of https://codereview.chromium.org/2800853002/ ) Reason for revert: I think, this patch causes the following errors: compile confirm no-op failing on 4 builders Linux x64 [10 since first detection] Mac [2 since first detection] Win [3 since first detection] Win x64 [3 since first detection] FYI ninja explain: output gen/blink/core/InspectorOverridesInl.h doesn't exist ninja explain: gen/blink/core/CoreProbesInl.h is dirty https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F36956%2F%2B%2Frecipes%2Fsteps%2Fcompile_confirm_no-op%2F0%2Fstdout Original issue's description: > [instrumentation] Turn inspector override "probes" return values into output parameters. > > This is a temporary measure. They should eventually become regular functions. > > BUG= 695625 > > Review-Url: https://codereview.chromium.org/2800853002 > Cr-Commit-Position: refs/heads/master@{#462286} > Committed: https://chromium.googlesource.com/chromium/src/+/66d34a387594b54f3fb22a30cb0fd57ff972a002 TBR=pfeldman@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 695625 Review-Url: https://codereview.chromium.org/2797253005 Cr-Commit-Position: refs/heads/master@{#462329} [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/probe/CoreProbes.h [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/probe/CoreProbes.pidl [modify] https://crrev.com/08edaf185f52af495778ce04d7f28c781031dc66/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e927e1d9502976b10a4da9551e7eaae7bb4f174 commit 3e927e1d9502976b10a4da9551e7eaae7bb4f174 Author: alph <alph@chromium.org> Date: Thu Apr 06 18:35:30 2017 [instrumentation] Turn inspector override "probes" return values into output parameters. This is a temporary measure. They should eventually become regular functions. BUG= 695625 Review-Url: https://codereview.chromium.org/2800853002 Cr-Original-Commit-Position: refs/heads/master@{#462286} Committed: https://chromium.googlesource.com/chromium/src/+/66d34a387594b54f3fb22a30cb0fd57ff972a002 Review-Url: https://codereview.chromium.org/2800853002 Cr-Commit-Position: refs/heads/master@{#462554} [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/probe/BUILD.gn [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/probe/CoreProbes.h [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/probe/CoreProbes.pidl [modify] https://crrev.com/3e927e1d9502976b10a4da9551e7eaae7bb4f174/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
Archiving feature requests that we are unlikely to address during the next 18 months.
Comment 1 by bugdroid1@chromium.org
, Feb 28 2017