New issue
Advanced search Search tips

Issue 695624 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 510836



Sign in to add a comment

TranslateManagerRenderViewHostTest.NormalTranslate fails with PlzNavigate

Project Member Reported by jam@chromium.org, Feb 23 2017

Issue description

This unit test fails with PlzNavigate. Since the codepaths are non-aura, I couldn't debug it on Windows. I tried debugging it on mac trybots but couldn't make progress.

Stuff like this is usually caused because the unit test harness doesn't wait long enough. I tried adding a webcontentsobserver to wait for DidFinishNavigate since that's what ContentTranslateDriver waits for, but that didn't work. See https://codereview.chromium.org/2714773002/#ps1.

Since it's just one test, and almost certainly a test harness issue, I'm going to disable it in the meantime so it doesn't block PlzNavigate switchover.
 
Components: -UI>Browser>Translate UI>Browser>Language>Translate

Comment 2 by groby@chromium.org, Apr 28 2017

Owner: ----
Status: Available (was: Assigned)
Cc: napper@chromium.org

Comment 4 by nasko@chromium.org, May 9 2017

Labels: Proj-PlzNavigate

Comment 5 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 6 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 7 by jam@chromium.org, Nov 7 2017

Components: -Internals>Services>Network
Cc: anthonyvd@chromium.org
Cc: yyushkina@chromium.org

Sign in to add a comment