win release component build broken |
||||
Issue descriptionstarted e.g. here https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/5714 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/builds/15544 FAILED: obj/content/renderer/renderer/render_view_impl.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/content/renderer/renderer/render_view_impl.obj.rsp /c ../../content/renderer/render_view_impl.cc /Foobj/content/renderer/renderer/render_view_impl.obj /Fd"obj/content/renderer/renderer_cc.pdb" In file included from ../../content/renderer/render_view_impl.cc:5: In file included from ../..\content/renderer/render_view_impl.h:11: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\deque:6: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\xmemory:6: C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(737,24): error: call to deleted constructor of 'std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >' ::new ((void *)_Ptr) _Objty(_STD forward<_Types>(_Args)...); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(857,7): note: in instantiation of function template specialization 'std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > >::construct<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &>' requested here _Al.construct(_Ptr, _STD forward<_Types>(_Args)...); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(995,14): note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::construct<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &>' requested here _Mytraits::construct(*this, _Ptr, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(225,7): note: in instantiation of function template specialization 'std::_Wrap_alloc<std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::construct<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &>' requested here _Al.construct(_Unfancy(_Dest), *_First); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(249,10): note: in instantiation of function template specialization 'std::_Uninitialized_copy_al_unchecked1<const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here return (_Uninitialized_copy_al_unchecked1(_First, _Last, _Dest, _Al, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(263,3): note: in instantiation of function template specialization 'std::_Uninitialized_copy_al_unchecked<const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here _Uninitialized_copy_al_unchecked(_Unchecked(_First), _Unchecked(_Last), ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(1652,11): note: in instantiation of function template specialization 'std::_Uninitialized_copy<std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > > >, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here return (_Uninitialized_copy(_First, _Last, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(751,22): note: in instantiation of function template specialization 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::_Ucopy<std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > > > >' requested here this->_Mylast() = _Ucopy(_Right.begin(), _Right.end(), ^ C:\b\c\b\CrWinAsan_dll_\src\content\renderer\media\webrtc\media_stream_track_metrics.h(33,22): note: in instantiation of member function 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::vector' requested here class CONTENT_EXPORT MediaStreamTrackMetrics : public base::NonThreadSafe { ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1435,2): note: 'unique_ptr' has been explicitly marked deleted here unique_ptr(const _Myt&) = delete; ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1193,21): error: invalid application of 'sizeof' to an incomplete type 'content::MediaStreamTrackMetricsObserver' static_assert(0 < sizeof (_Ty), ^~~~~~~~~~~~ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1397,4): note: in instantiation of member function 'std::default_delete<content::MediaStreamTrackMetricsObserver>::operator()' requested here this->get_deleter()(get()); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(744,10): note: in instantiation of member function 'std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >::~unique_ptr' requested here _Ptr->~_Uty(); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(864,7): note: in instantiation of function template specialization 'std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > >::destroy<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > >' requested here _Al.destroy(_Ptr); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(1003,14): note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::destroy<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > >' requested here _Mytraits::destroy(*this, _Ptr); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(1101,7): note: in instantiation of function template specialization 'std::_Wrap_alloc<std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::destroy<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > >' requested here _Al.destroy(_Unfancy(_First)); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(1118,2): note: (skipping 2 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all) _Destroy_range1(_First, _Last, _Al, typename conjunction< ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(249,10): note: in instantiation of function template specialization 'std::_Uninitialized_copy_al_unchecked1<const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here return (_Uninitialized_copy_al_unchecked1(_First, _Last, _Dest, _Al, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(263,3): note: in instantiation of function template specialization 'std::_Uninitialized_copy_al_unchecked<const std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here _Uninitialized_copy_al_unchecked(_Unchecked(_First), _Unchecked(_Last), ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(1652,11): note: in instantiation of function template specialization 'std::_Uninitialized_copy<std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > > >, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here return (_Uninitialized_copy(_First, _Last, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(751,22): note: in instantiation of function template specialization 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::_Ucopy<std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > > > >' requested here this->_Mylast() = _Ucopy(_Right.begin(), _Right.end(), ^ C:\b\c\b\CrWinAsan_dll_\src\content\renderer\media\webrtc\media_stream_track_metrics.h(33,22): note: in instantiation of member function 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::vector' requested here class CONTENT_EXPORT MediaStreamTrackMetrics : public base::NonThreadSafe { ^ C:\b\c\b\CrWinAsan_dll_\src\content\renderer\media\webrtc\media_stream_track_metrics.h(23,7): note: forward declaration of 'content::MediaStreamTrackMetricsObserver' class MediaStreamTrackMetricsObserver; ^ In file included from ../../content/renderer/render_view_impl.cc:5: In file included from ../..\content/renderer/render_view_impl.h:11: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\deque:6: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\xmemory:6: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\xmemory0:10: C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xutility(2316,10): error: overload resolution selected deleted operator '=' *_Dest = *_First; ~~~~~~ ^ ~~~~~~~ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xutility(2334,10): note: in instantiation of function template specialization 'std::_Copy_unchecked1<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *>' requested here return (_Copy_unchecked1(_First, _Last, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(996,20): note: in instantiation of function template specialization 'std::_Copy_unchecked<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *>' requested here pointer _Ptr = _Copy_unchecked(_Right._Myfirst(), ^ C:\b\c\b\CrWinAsan_dll_\src\content\renderer\media\webrtc\media_stream_track_metrics.h(33,22): note: in instantiation of member function 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::operator=' requested here class CONTENT_EXPORT MediaStreamTrackMetrics : public base::NonThreadSafe { ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1436,8): note: candidate function has been explicitly deleted _Myt& operator=(const _Myt&) = delete; ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1303,8): note: candidate function not viable: no known conversion from 'std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >' to 'nullptr_t' for 1st argument _Myt& operator=(nullptr_t) _NOEXCEPT ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1370,3): note: candidate function [with _Ty2 = content::MediaStreamTrackMetricsObserver, _Dx2 = std::default_delete<content::MediaStreamTrackMetricsObserver>] not viable: no known conversion from 'std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >' to 'unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &&' for 1st argument operator=(unique_ptr<_Ty2, _Dx2>&& _Right) _NOEXCEPT ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1377,8): note: candidate function not viable: no known conversion from 'std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >' to '_Myt &&' (aka 'unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &&') for 1st argument _Myt& operator=(_Myt&& _Right) _NOEXCEPT ^ In file included from ../../content/renderer/render_view_impl.cc:5: In file included from ../..\content/renderer/render_view_impl.h:11: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\deque:6: In file included from C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\win_sdk\bin\..\..\VC\include\xmemory:6: C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(737,24): error: call to deleted constructor of 'std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >' ::new ((void *)_Ptr) _Objty(_STD forward<_Types>(_Args)...); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(857,7): note: in instantiation of function template specialization 'std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > >::construct<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &>' requested here _Al.construct(_Ptr, _STD forward<_Types>(_Args)...); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory0(995,14): note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::construct<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &>' requested here _Mytraits::construct(*this, _Ptr, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(225,7): note: in instantiation of function template specialization 'std::_Wrap_alloc<std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::construct<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > &>' requested here _Al.construct(_Unfancy(_Dest), *_First); ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(249,10): note: in instantiation of function template specialization 'std::_Uninitialized_copy_al_unchecked1<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here return (_Uninitialized_copy_al_unchecked1(_First, _Last, _Dest, _Al, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\xmemory(263,3): note: in instantiation of function template specialization 'std::_Uninitialized_copy_al_unchecked<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here _Uninitialized_copy_al_unchecked(_Unchecked(_First), _Unchecked(_Last), ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(1652,11): note: in instantiation of function template specialization 'std::_Uninitialized_copy<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >' requested here return (_Uninitialized_copy(_First, _Last, ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\vector(1006,23): note: in instantiation of function template specialization 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::_Ucopy<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > *>' requested here this->_Mylast() = _Ucopy(_Ptr, _Right._Mylast(), ^ C:\b\c\b\CrWinAsan_dll_\src\content\renderer\media\webrtc\media_stream_track_metrics.h(33,22): note: in instantiation of member function 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> >, std::allocator<std::unique_ptr<content::MediaStreamTrackMetricsObserver, std::default_delete<content::MediaStreamTrackMetricsObserver> > > >::operator=' requested here class CONTENT_EXPORT MediaStreamTrackMetrics : public base::NonThreadSafe { ^ C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\include\memory(1435,2): note: 'unique_ptr' has been explicitly marked deleted here unique_ptr(const _Myt&) = delete; ^ 4 errors generated. Probably triggered by https://codereview.chromium.org/2705073003 hans, compiler bug or code bug? I guess we have no MSVC release component bots, so I don't know if it works there.
,
Feb 23 2017
,
Feb 23 2017
https://codereview.chromium.org/2712913003/ fixes render_view_impl.obj compiling the rest now..
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f087f34d91e04c8890502ac10dfb371da1a0f20c commit f087f34d91e04c8890502ac10dfb371da1a0f20c Author: hans <hans@chromium.org> Date: Thu Feb 23 21:59:28 2017 Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN After https://codereview.chromium.org/2705073003, the Windows release component build would fail due to the compiler trying to instantiate the assignment operator and copy constructor due to the class being dllexport, and fail because it now uses unique_ptr. BUG= 695584 TBR=avi Review-Url: https://codereview.chromium.org/2712913003 Cr-Commit-Position: refs/heads/master@{#452646} [modify] https://crrev.com/f087f34d91e04c8890502ac10dfb371da1a0f20c/content/renderer/media/webrtc/media_stream_track_metrics.h
,
Feb 23 2017
The 'chrome' target built successfully. Hopefully we're good.
,
Jun 9 2017
Hello. I tried to apply the same fix from Comment 4, on Linux, for the following error but it has no effect. Could someone suggest a fix, please?
ccache ../../../usr/bin/clang++ -MMD -MF obj/content/renderer/renderer/media_factory.o.d -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DDISABLE_NACL -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"303910-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCONTENT_IMPLEMENTATION -DENABLE_IPC_FUZZER -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DV8_USE_EXTERNAL_STARTUP_DATA -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DLOG_DISABLED=0 -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src -Igen -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/khronos -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/gpu -Igen/shim_headers/ffmpeg_shim -Igen/shim_headers/libvpx_shim -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/ced/src -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/icu/source/common -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/icu/source/i18n -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/libwebm/source -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/skia/config -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/skia/ext -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/c -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/config -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/core -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/effects -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/encode -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/images -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/lazy -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/pathops -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/pdf -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/pipe -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/ports -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/utils -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/third_party/vulkan -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/include/gpu -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/src/gpu -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/skia/src/sksl -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/protobuf/src -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/boringssl/src/include -I/usr/include/nss -I/usr/include/nspr -Igen -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/WebKit -Igen/third_party/WebKit -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/v8/include -Igen/v8/include -Igen/components/metrics/proto -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/WebKit/Source -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/v8/include -Igen/v8/include -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/mesa/src/include -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/webrtc_overrides -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/testing/gtest/include -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/webrtc_overrides -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party -I../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/third_party/libyuv/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -D_FORTIFY_SOURCE=2 -fomit-frame-pointer -fno-omit-frame-pointer -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-user-defined-warnings -Ofast -fno-fast-math -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g1 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wno-header-guard -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/content/renderer/media/media_factory.cc -o obj/content/renderer/renderer/media_factory.o
In file included from ../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/content/renderer/media/media_factory.cc:5:
In file included from ../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/content/renderer/media/media_factory.h:8:
In file included from /tmp/out/Default/../../../usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.1.1/../../../../include/c++/7.1.1/memory:80:
/tmp/out/Default/../../../usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.1.1/../../../../include/c++/7.1.1/bits/unique_ptr.h:76:16: error: invalid application of 'sizeof' to an incomplete type 'media::CdmFactory'
static_assert(sizeof(_Tp)>0,
^~~~~~~~~~~
/tmp/out/Default/../../../usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/7.1.1/../../../../include/c++/7.1.1/bits/unique_ptr.h:268:4: note: in instantiation of member function 'std::default_delete<media::CdmFactory>::operator()' requested here
get_deleter()(__ptr);
^
../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/content/renderer/media/media_factory.cc:78:15: note: in instantiation of member function 'std::unique_ptr<media::CdmFactory, std::default_delete<media::CdmFactory> >::~unique_ptr' requested here
MediaFactory::MediaFactory(
^
../../../home/xftroxgpx/build/1packages/chro/4_chromium-dev-git/fetch_gclient_base/checkout_root/src/content/renderer/media/media_factory.h:35:7: note: forward declaration of 'media::CdmFactory'
class CdmFactory;
^
1 error generated.
,
Jun 9 2017
found the fix, sorry for the noise |
||||
►
Sign in to add a comment |
||||
Comment 1 by h...@chromium.org
, Feb 23 2017> hans, compiler bug or code bug? I guess we have no MSVC release component bots, so I don't know if it works there. MSVC doesn't like it either. args.gn: is_clang = false is_component_build = true is_debug = false strip_absolute_paths_from_debug_symbols = true symbol_level = 1 target_cpu = "x86" D:\src\chromium\src>ninja -C out\release obj/content/renderer/renderer/render_vi ew_impl.obj ninja: Entering directory `out\release' [4342/4342] CXX obj/content/renderer/renderer/render_view_impl.obj FAILED: obj/content/renderer/renderer/render_view_impl.obj ninja -t msvc -e environment.x86 -- "d:\src\depot_tools\win_toolchain\vs_files\d 3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIn cludes /FC @obj/content/renderer/renderer/render_view_impl.obj.rsp /c ../../cont ent/renderer/render_view_impl.cc /Foobj/content/renderer/renderer/render_view_im pl.obj /Fd"obj/content/renderer/renderer_cc.pdb" d:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be456 16\vc\include\xutility(2316): error C2280: 'std::unique_ptr<content::MediaStream TrackMetricsObserver,std::default_delete<_Ty>> &std::unique_ptr<_Ty,std::default _delete<_Ty>>::operator =(const std::unique_ptr<_Ty,std::default_delete<_Ty>> &) ': attempting to reference a deleted function with [ _Ty=content::MediaStreamTrackMetricsObserver ] d:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be456 16\vc\include\memory(1436): note: see declaration of 'std::unique_ptr<content::M ediaStreamTrackMetricsObserver,std::default_delete<_Ty>>::operator =' with [ _Ty=content::MediaStreamTrackMetricsObserver ] d:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be456 16\vc\include\xutility(2335): note: see reference to function template instantia tion '_OutIt std::_Copy_unchecked1<_InIt,_OutIt>(_InIt,_InIt,_OutIt,std::_Genera l_ptr_iterator_tag)' being compiled with [ _OutIt=std::unique_ptr<content::MediaStreamTrackMetricsObserver,std: :default_delete<content::MediaStreamTrackMetricsObserver>> *, _InIt=std::unique_ptr<content::MediaStreamTrackMetricsObserver,std:: default_delete<content::MediaStreamTrackMetricsObserver>> * ] d:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be456 16\vc\include\vector(997): note: see reference to function template instantiatio n '_OutIt *std::_Copy_unchecked<std::unique_ptr<content::MediaStreamTrackMetrics Observer,std::default_delete<_Ty>>*,std::unique_ptr<_Ty,std::default_delete<_Ty> >*>(_InIt,_InIt,_OutIt)' being compiled with [ _OutIt=std::unique_ptr<content::MediaStreamTrackMetricsObserver,std: :default_delete<content::MediaStreamTrackMetricsObserver>> *, _Ty=content::MediaStreamTrackMetricsObserver, _InIt=std::unique_ptr<content::MediaStreamTrackMetricsObserver,std:: default_delete<content::MediaStreamTrackMetricsObserver>> * ] d:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be456 16\vc\include\vector(980): note: while compiling class template member function 'std::vector<std::unique_ptr<content::MediaStreamTrackMetricsObserver,std::defau lt_delete<_Ty>>,std::allocator<std::unique_ptr<_Ty,std::default_delete<_Ty>>>> & std::vector<std::unique_ptr<_Ty,std::default_delete<_Ty>>,std::allocator<std::un ique_ptr<_Ty,std::default_delete<_Ty>>>>::operator =(const std::vector<std::uniq ue_ptr<_Ty,std::default_delete<_Ty>>,std::allocator<std::unique_ptr<_Ty,std::def ault_delete<_Ty>>>> &)' with [ _Ty=content::MediaStreamTrackMetricsObserver ] d:\src\chromium\src\content\renderer\media\webrtc\media_stream_track_metrics.h(1 00): note: see reference to function template instantiation 'std::vector<std::un ique_ptr<content::MediaStreamTrackMetricsObserver,std::default_delete<_Ty>>,std: :allocator<std::unique_ptr<_Ty,std::default_delete<_Ty>>>> &std::vector<std::uni que_ptr<_Ty,std::default_delete<_Ty>>,std::allocator<std::unique_ptr<_Ty,std::de fault_delete<_Ty>>>>::operator =(const std::vector<std::unique_ptr<_Ty,std::defa ult_delete<_Ty>>,std::allocator<std::unique_ptr<_Ty,std::default_delete<_Ty>>>> &)' being compiled with [ _Ty=content::MediaStreamTrackMetricsObserver ] d:\src\chromium\src\content\renderer\media\webrtc\media_stream_track_metrics.h(9 7): note: see reference to class template instantiation 'std::vector<std::unique _ptr<content::MediaStreamTrackMetricsObserver,std::default_delete<_Ty>>,std::all ocator<std::unique_ptr<_Ty,std::default_delete<_Ty>>>>' being compiled with [ _Ty=content::MediaStreamTrackMetricsObserver ] ninja: build stopped: subcommand failed.