New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695578 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
dpa...@chromium.org
█ dschuyler@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 671375



Sign in to add a comment

MD Settings: Allow editing content settings exceptions for various categories

Project Member Reported by dpa...@chromium.org, Feb 23 2017 
In the old Options exceptions could be edited for the following categories: 
 - cookies
 - automatic downloads
 - images
 - javascript
 - popups
 - notifications

In the new MD Settings none of these can be edited. CGookies editing is being implemented at https://codereview.chromium.org/2699013002. It should be relatively easy to allow editing exceptions from the remaining categories, since the underlying infrastructure is the same for all exceptions.

Comment 1 by dbeam@chromium.org, Feb 23 2017

Blocking: 671375
Labels: Hotlist-MD-Settings-Privacy-SiteSettings
Status: Available (was: Untriaged)

Comment 2 by dbeam@chromium.org, Feb 23 2017 

not a P1 because remove + re-add is an alternative
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188b7bdc8292a7b740f7caa3d26bfd89aac5a924

commit 188b7bdc8292a7b740f7caa3d26bfd89aac5a924
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 24 01:49:23 2017

MD Settings: Allow editing a cookie site exception.

BUG= 657639 , 695578 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2699013002
Cr-Commit-Position: refs/heads/master@{#452712}

[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/app/settings_strings.grdp
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[add] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[add] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/188b7bdc8292a7b740f7caa3d26bfd89aac5a924/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

Comment 4 by steve...@chromium.org, Mar 4 2017

Owner: dpa...@chromium.org

Comment 5 by dschuyler@chromium.org, Mar 16 2017

Owner: dschuyler@chromium.org
Status: Started (was: Available)

Comment 7 by dbeam@chromium.org, Mar 17 2017

Labels: M-59
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09ce829191004d5e0599f6dcd0dcc1491214f11d

commit 09ce829191004d5e0599f6dcd0dcc1491214f11d
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Mar 21 00:41:18 2017

[MD settings] edit content settings exceptions

This CL enables the edit dialog for content settings exceptions beyond
the cookies category. Specifically: Automatic Downloads, Background
Sync, Images, JavaScript, Notifications, Plugins, Popups, and
Unsandboxed Plugins. The intention is to match which exceptions are
editable in the old options.

BUG= 695578 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2749023008
Cr-Commit-Position: refs/heads/master@{#458258}

[modify] https://crrev.com/09ce829191004d5e0599f6dcd0dcc1491214f11d/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/09ce829191004d5e0599f6dcd0dcc1491214f11d/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/09ce829191004d5e0599f6dcd0dcc1491214f11d/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/09ce829191004d5e0599f6dcd0dcc1491214f11d/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/09ce829191004d5e0599f6dcd0dcc1491214f11d/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/09ce829191004d5e0599f6dcd0dcc1491214f11d/chrome/test/data/webui/settings/site_list_tests.js

Comment 9 by dschuyler@chromium.org, Mar 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment