New issue
Advanced search Search tips

Issue 695566 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 693114



Sign in to add a comment

Decide if dip_unittest should be ported to mash

Project Member Reported by sky@chromium.org, Feb 23 2017

Issue description

It currently uses display_manager() which doesn't exist for mash.
 

Comment 1 by sky@chromium.org, Feb 23 2017

Cc: kylec...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8782ff08a3ed45882f707658d63cb25cf403187f

commit 8782ff08a3ed45882f707658d63cb25cf403187f
Author: sky <sky@chromium.org>
Date: Thu Feb 23 22:12:42 2017

chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556, 695559 , 695562 , 695563 , 695561 , 695563 , 695565 , 695566 , 695569 ,695570
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2713923002
Cr-Commit-Position: refs/heads/master@{#452652}

[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/BUILD.gn
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_button_pressed_metric_tracker_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/test/ash_test.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/mus/bridge/wm_shell_mus.cc

Comment 3 by sky@chromium.org, Mar 7 2017

Blocking: 693114

Comment 4 by sky@chromium.org, Mar 30 2017

Labels: mustash-2
Status: WontFix (was: Untriaged)
Obsolete
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment