New issue
Advanced search Search tips

Issue 695565 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 693114



Sign in to add a comment

Handful of tests in ShelfButtonPressedMetricTrackerTest fail in mash

Project Member Reported by sky@chromium.org, Feb 23 2017

Issue description

Note sure if this indicates the test needs to be updated for mash, or a more fundamental problem.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8782ff08a3ed45882f707658d63cb25cf403187f

commit 8782ff08a3ed45882f707658d63cb25cf403187f
Author: sky <sky@chromium.org>
Date: Thu Feb 23 22:12:42 2017

chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556, 695559 , 695562 , 695563 , 695561 , 695563 , 695565 , 695566 , 695569 ,695570
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2713923002
Cr-Commit-Position: refs/heads/master@{#452652}

[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/BUILD.gn
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_button_pressed_metric_tracker_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/test/ash_test.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/mus/bridge/wm_shell_mus.cc

Comment 2 by sky@chromium.org, Mar 7 2017

Blocking: 693114
Cc: -jamescook@chromium.org msw@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Assigned)
They work now, I'll land a CL to enable them.

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b5ae7afcc708aa5b2cdd9cac30d4790a347440

commit 07b5ae7afcc708aa5b2cdd9cac30d4790a347440
Author: James Cook <jamescook@chromium.org>
Date: Thu Nov 02 22:04:32 2017

cros: Enable ShelfButtonMetricTrackTest under --mash

It passes now.

Bug:  695565 
Test: ash_unittests --mash
Change-Id: I25123e1a29c82a021b76e63f7052e1ee13dab397
Reviewed-on: https://chromium-review.googlesource.com/752062
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513613}
[modify] https://crrev.com/07b5ae7afcc708aa5b2cdd9cac30d4790a347440/ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment