New issue
Advanced search Search tips

Issue 695563 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 693114



Sign in to add a comment

ShelfTooltipManagerTest.HideForEvents and HideForExternalEvents fail in mash

Project Member Reported by sky@chromium.org, Feb 23 2017

Issue description

Note sure if this indicates the test needs to be updated for mash, or a more fundamental problem.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8782ff08a3ed45882f707658d63cb25cf403187f

commit 8782ff08a3ed45882f707658d63cb25cf403187f
Author: sky <sky@chromium.org>
Date: Thu Feb 23 22:12:42 2017

chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556, 695559 , 695562 , 695563 , 695561 , 695563 , 695565 , 695566 , 695569 ,695570
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2713923002
Cr-Commit-Position: refs/heads/master@{#452652}

[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/BUILD.gn
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_button_pressed_metric_tracker_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/test/ash_test.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/mus/bridge/wm_shell_mus.cc

Comment 2 by sky@chromium.org, Mar 7 2017

Blocking: 693114
Components: Tests>Disabled
Labels: Test-Disabled
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67827ab7ae7a329bcb7aa10fab37154f58363db3

commit 67827ab7ae7a329bcb7aa10fab37154f58363db3
Author: Mike Wasserman <msw@chromium.org>
Date: Wed Feb 07 00:29:54 2018

Enable shelf and panel ash_unittests in mash

These tests appear to pass as-is on ToT @ #534716.

Bug:  695563 ,  698887 ,  775177 
Test: Automated
Change-Id: I6d3979aec6738e4d14c2119faa3488d0ee1c596e
Reviewed-on: https://chromium-review.googlesource.com/905687
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534850}
[modify] https://crrev.com/67827ab7ae7a329bcb7aa10fab37154f58363db3/ash/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/67827ab7ae7a329bcb7aa10fab37154f58363db3/ash/wm/panels/panel_layout_manager_unittest.cc

Comment 6 by msw@chromium.org, Feb 7 2018

Status: Fixed (was: Assigned)

Sign in to add a comment