Not sure if the test needs to be updated, or this indicates a real problem.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8782ff08a3ed45882f707658d63cb25cf403187f commit 8782ff08a3ed45882f707658d63cb25cf403187f Author: sky <sky@chromium.org> Date: Thu Feb 23 22:12:42 2017 chromeos: moves a bunch of tests to common_unittests These all work with both ash and mash now. I've had to effectively disable some for mash only, and have filed bugs. TEST=test only change BUG=695556, 695559 , 695562 , 695563 , 695561 , 695563 , 695565 , 695566 , 695569 ,695570 R=msw@chromium.org Review-Url: https://codereview.chromium.org/2713923002 Cr-Commit-Position: refs/heads/master@{#452652} [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/BUILD.gn [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/autoclick/autoclick_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_button_pressed_metric_tracker_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/tray/system_tray_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/test/ash_test.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/extended_desktop_unittest.cc [modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/mus/bridge/wm_shell_mus.cc
I'll take this.
SystemTrayTest.Activation was a real problem with accelerators. I fixed it with https://codereview.chromium.org/2752643002/ SystemTrayTest.PersistentBubble is a different issue, possibly related to ui::test::EventGenerator. I'm looking now.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03ae5b6069bab8e87953072eeb75a192b6e6d6aa commit 03ae5b6069bab8e87953072eeb75a192b6e6d6aa Author: jamescook <jamescook@chromium.org> Date: Fri Mar 17 03:40:03 2017 Make ui::test::EventGenerator work with PointerEvents in mash In classic ash PointerWatchers are triggered by an EventHandler attached to ash::Shell and are triggered in unit tests using EventGenerator. In mash PointerWatchers are triggered by a PointerWatcherEventRouter owned by ash::mus::WindowManager. That code path wasn't getting hit in unit tests using EventGenerator. Wiring it up fixes SystemTrayTest.PersistentBubble in mash. It will probably fix several other tests disabled in mash. We'll find those as we look at them individually -- there's no simple way to re-enable all those tests to try them. BUG= 693790 , 695559 TEST=ash_unittests, mash_unittests SystemTrayTest.PersisentBubble Review-Url: https://codereview.chromium.org/2752903002 Cr-Commit-Position: refs/heads/master@{#457677} [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ash/common/system/tray/system_tray_unittest.cc [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ash/mus/window_manager.h [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/aura/env.h [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/aura/test/env_test_helper.h [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/aura/test/event_generator_delegate_aura.cc [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/aura/test/event_generator_delegate_aura.h [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/aura/test/mus/window_tree_client_private.cc [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/aura/test/mus/window_tree_client_private.h [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/events/test/event_generator.cc [modify] https://crrev.com/03ae5b6069bab8e87953072eeb75a192b6e6d6aa/ui/events/test/event_generator.h
Comment 1 by sky@chromium.org
, Feb 23 2017