Set focus to password field on lock screen on typing. |
||||||||||||||||||
Issue descriptionIt's easy to get into a state where the password field in the lock screen doesn't have focus. This is expected in case the user wants to trigger shutdown or whatever from the keyboard. If the user starts typing valid password characters though, those don't make sense for any other control on the lock screen. We should snap focus back to the pod if the user starts typing.
,
Mar 16 2017
,
Mar 16 2017
,
Apr 20 2017
+Jacob, something we could include with lockscreen refresh?
,
Apr 20 2017
Hopefully. Might land after the initial update, though.
,
Apr 26 2017
,
Apr 27 2017
Colin, if this one will require re-writing in the new sign-in / lock screen implementation, let's wait until that is working and do it once.
,
Apr 27 2017
Zach, yes we can wait.
,
Jul 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adbb2f05fba881a21694142c85513a0693054a5d commit adbb2f05fba881a21694142c85513a0693054a5d Author: Wenzhao Zang <wzang@chromium.org> Date: Sat Jul 22 19:14:00 2017 Auto-focus on password field when a valid char is entered at login/lock screen When a valid password beginning character is entered and is not not handled by anywhere else, auto focus on the main pod and treat the key as the password start. Bug: 695558 Change-Id: I82145376867690567c94a203db706c29e42dc4b2 Reviewed-on: https://chromium-review.googlesource.com/581755 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#488870} [modify] https://crrev.com/adbb2f05fba881a21694142c85513a0693054a5d/ui/login/account_picker/md_user_pod_row.js
,
Jul 24 2017
,
Jul 24 2017
Hopefully this is fine, but cc-ing Jorge as security heads-up.
,
Jul 24 2017
I cannot think quickly of a way that this would be bad. It would be great though to run these security-sensitive changes by the security team, the same way the security team runs UI-sensitive changes by the UI team.
,
Aug 8 2017
,
Aug 8 2017
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 8 2017
,
Aug 8 2017
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 8 2017
+ketakid@ for merge approval
,
Aug 9 2017
This is not a feature but is part of the fix the the existing losing focus issues. Maybe 'Type' should be changed to 'Bug'.
,
Aug 9 2017
,
Aug 9 2017
,
Aug 9 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dac3227351c3820711b35d9f457276e230a243e5 commit dac3227351c3820711b35d9f457276e230a243e5 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 00:28:20 2017 Auto-focus on password field when a valid char is entered at login/lock screen When a valid password beginning character is entered and is not not handled by anywhere else, auto focus on the main pod and treat the key as the password start. TBR=wzang@chromium.org (cherry picked from commit adbb2f05fba881a21694142c85513a0693054a5d) Bug: 695558 Change-Id: I82145376867690567c94a203db706c29e42dc4b2 Reviewed-on: https://chromium-review.googlesource.com/581755 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488870} Reviewed-on: https://chromium-review.googlesource.com/609500 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#419} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/dac3227351c3820711b35d9f457276e230a243e5/ui/login/account_picker/md_user_pod_row.js
,
Jan 22 2018
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by zalcorn@chromium.org
, Mar 16 2017