The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8782ff08a3ed45882f707658d63cb25cf403187f

commit 8782ff08a3ed45882f707658d63cb25cf403187f
Author: sky <sky@chromium.org>
Date: Thu Feb 23 22:12:42 2017

chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556, 695559 , 695562 , 695563 , 695561 , 695563 , 695565 , 695566 , 695569 ,695570
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2713923002
Cr-Commit-Position: refs/heads/master@{#452652}

[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/BUILD.gn
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_button_pressed_metric_tracker_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/test/ash_test.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/8782ff08a3ed45882f707658d63cb25cf403187f/ash/mus/bridge/wm_shell_mus.cc

I think we might need to make some changes in mus-ws as well. mus-ws uses display::DisplayManager which keeps track of rotation. It'll output adisplay::Display with the appropriate rotation and size. mus-ws never uses that information so it's probably broken, unless ash handles the rotation itself.

Is this a priority at all in Q1?

No, this isn't a priority for Q1.
I'm going through and filing bugs against all existing ash tests that don't work in mash.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea37af717f1569dd93282e09b6fb49ff22b771f8

commit ea37af717f1569dd93282e09b6fb49ff22b771f8
Author: sky <sky@chromium.org>
Date: Tue Mar 07 22:59:41 2017

Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG= 622486 , 631103 , 637853 , 648733 ,695556, 696028 ,698091, 698129 , 698878 , 698887 ,698888,698892,698894, 698895 , 698914 ,699172,699175, 693114 
TEST=test changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2739703003
Cr-Commit-Position: refs/heads/master@{#455272}

[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/BUILD.gn
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/test/ash_test_base.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_window_resizer_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8675cbb337440a11bf9afb10ea11bae42bb92cb

commit f8675cbb337440a11bf9afb10ea11bae42bb92cb
Author: James Cook <jamescook@chromium.org>
Date: Fri Nov 03 17:59:35 2017

cros: Enable some tests in //ash/wm in ash_unittests --mash

For the ones that fail, disable them via filter file instead of in the
code, per our disablement policy.

Bug: 698085, 695556,  698878 , 698888, 698093, 698894
Test: ash_unittests --mash
Change-Id: Ic145ab6a95508968d6884d14fac2a3ca08888d26
Reviewed-on: https://chromium-review.googlesource.com/752423
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513836}
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/testing/buildbot/filters/ash_unittests_mash.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5

commit d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5
Author: James Cook <jamescook@chromium.org>
Date: Fri Dec 08 00:53:39 2017

cros: Clean up mash early-exits in ash_unittests --mash

Our policy for mash is to disable via filter file unless the test is
never expected to work under mash.

Also re-enable a bunch of tests that now pass under mash, likely due to
the display manager work done several months ago.

Bug: 695556,  696752 ,  698024 ,  696006 ,  581462 ,  698129 ,  726838 
Test: ash_unittests for classic, --mus and --mash
Change-Id: Ia192d77b107c2a9f93ab4e0416b2f4fdb63b3f8d
Reviewed-on: https://chromium-review.googlesource.com/815874
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522655}
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/display/display_configuration_controller_unittest.cc
[delete] https://crrev.com/ef9ad27b1a663fa6e434fb32a03ca3275ea79134/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/screen_util_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/shell_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/window_manager_common_unittests.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/testing/buildbot/filters/ash_unittests_mash.filter