New issue
Advanced search Search tips

Issue 695553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

W3C test importer failed to update expectations and upload patchset for csswg-test

Project Member Reported by qyears...@chromium.org, Feb 23 2017

Issue description

Example failed job:

https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7971
CL: https://codereview.chromium.org/2707203005

Example try job for that CL:
https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/5493

Note that there's a failure in "apply patch":

===Running apply_issue --root_dir src --issue 2707203005 --server https://codereview.chromium.org --force --ignore_deps --no-auth --patchset 1 --whitelist DEPS (attempt #1)===
In directory: /b/c/b/linux_layout
Connecting to https://codereview.chromium.org
Downloading patch from https://codereview.chromium.org/2707203005/#ps1
Traceback (most recent call last):
  File "/b/depot_tools/apply_issue.py", line 322, in <module>
    sys.exit(main())
  ...
patch.UnsupportedPatchFormat: Can't process patch for file third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/support/mplus-1p-regular.ttf.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

Since this involves apply_issue, this may be resolved by migrating to Gerrit ( bug 693792 ).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f

commit bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Feb 24 17:50:22 2017

Import csswg-test@ed79f8614481e97d61f17f41b65448c211d27c6f

Using wpt-import in Chromium 9868886dfba0439ec305b876d4ef513b13765752.

NOEXPORT=true
BUG= 695553 

Change-Id: I52cbb9899b27e0f247d39716ab9a636d0776491c
Reviewed-on: https://chromium-review.googlesource.com/446738
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#452865}
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-alignment-001-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-alignment-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-alignment-002-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-alignment-002.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-computed-style-expected.txt
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-computed-style.html
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/100x100-green.png
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/100x50-green.png
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/200x200-green.png
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/50x100-green.png
[rename] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-basic-001-expected.html
[rename] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-basic-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-boundary-001-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-boundary-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-dynamic-001-expected.txt
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-dynamic-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-parsing-001-expected.txt
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-parsing-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-ruby-001-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-ruby-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-valign-001-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-valign-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-writing-mode-vrl-001-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-writing-mode-vrl-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-writing-mode-vrl-ruby-001-expected.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/line-height-step-writing-mode-vrl-ruby-001.html
[delete] https://crrev.com/41275be19538321629de8a93ec9fd4665e0a4b91/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/snap-height-baseline-001-expected.html
[delete] https://crrev.com/41275be19538321629de8a93ec9fd4665e0a4b91/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/snap-height-baseline-001.html
[delete] https://crrev.com/41275be19538321629de8a93ec9fd4665e0a4b91/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/snap-height-dynamic-001.html
[delete] https://crrev.com/41275be19538321629de8a93ec9fd4665e0a4b91/third_party/WebKit/LayoutTests/external/csswg-test/css-rhythm-1/snap-height-parsing-001.html
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vlr-003-expected.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vlr-003.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vlr-005-expected.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vlr-005.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vrl-002-expected.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vrl-002.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vrl-004-expected.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/normal-flow-overconstrained-vrl-004.xht
[add] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/support/mplus-1p-regular.ttf
[modify] https://crrev.com/bfd0e6fb771f7c913e8df9bd853cb8d76dd7fa6f/third_party/WebKit/LayoutTests/external/csswg-test/css-writing-modes-3/text-combine-upright-value-all-001.html

Status: Fixed (was: Assigned)
So the result was, making the change with Gerrit worked, the immediate issue is now bypassed, and the long-term fix is to migrate to Gerrit.
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment