in harmony, this tree view doesn't even exist. I think as a stopgap, instead of fixing the dotted lines, we should just use a blue focus outline since that's what we use basically everywhere else.
also the blue focus rects look bad
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f084da03407bcb848d8ef8f232c28db56883d648 commit f084da03407bcb848d8ef8f232c28db56883d648 Author: estade <estade@chromium.org> Date: Fri Feb 24 18:21:57 2017 Change focus indicator for TableView and TreeView. This affects surfaces such as the task manager, the bookmark bubble editor, and the cookies view. The indicator for selection (the background of the row) is unchanged. When the window is focused, instead of drawing a dashed focus rect which looks dated and especially bad at fractional scales, we draw the table/tree's border in blue. This matches textfields and the general trend of blue outlines/rings for focus indication. This will change in Harmony to be a focus ring so it's mainly just an interim solution that makes the current state of the world look less bad while we wait for Harmony to arrive. BUG= 695540 Review-Url: https://codereview.chromium.org/2715813002 Cr-Commit-Position: refs/heads/master@{#452876} [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/chrome/browser/ui/views/collected_cookies_views.cc [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/controls/scroll_view.cc [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/controls/scroll_view.h [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/controls/table/table_view.cc [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/controls/tree/tree_view.cc [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/controls/tree/tree_view.h [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/style/platform_style.cc [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/style/platform_style.h [modify] https://crrev.com/f084da03407bcb848d8ef8f232c28db56883d648/ui/views/style/platform_style_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/046559ce9c88712b6226947bc4b2d186bd3a1d12 commit 046559ce9c88712b6226947bc4b2d186bd3a1d12 Author: estade <estade@chromium.org> Date: Mon Feb 27 19:19:21 2017 Improve appearance of focus rings at fractional scales. Focus rings are floored to the nearest integral number of pixels. This matches what we do for solid borders. This only addresses the second part of the linked bug; updating TreeView and TableView will come later. TBR=derat@chromium.org BUG= 695540 Review-Url: https://codereview.chromium.org/2714753002 Cr-Commit-Position: refs/heads/master@{#453289} [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ash/common/ash_constants.cc [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ash/common/ash_constants.h [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ui/gfx/canvas.cc [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ui/gfx/canvas.h [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ui/views/controls/slider.cc [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ui/views/painter.cc [modify] https://crrev.com/046559ce9c88712b6226947bc4b2d186bd3a1d12/ui/views/painter.h
Comment 1 by est...@chromium.org
, Feb 23 20177.9 KB
7.9 KB View Download