New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695538 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Track more detailed error codes from UMA and UKM

Project Member Reported by rkaplow@chromium.org, Feb 23 2017

Issue description

Currently we just track the response code in the UMA and UKM status records, i..e

UMA.UploadResponseStatus.Protobuf 
UKM.Upload.ResponseCode

however we don't get the error breakdowns, just -1.

We should get the breakdowns as we do in variations:

https://codesearch.chromium.org/chromium/src/components/variations/service/variations_service.cc?type=cs&q=Variations.SeedFetchResponseOrErrorCode&l=658
 
Cc: holte@chromium.org
We get some alerts about the current metric with "no response" bucket being more prevalent under Enabled_NoDelay group of UMAUploadScheduler: 

https://uma.googleplex.com/variations?sid=0373829b6a2ae60e9f68d09e4259b7eb

"no response" is actually when we get an error from the network stack. So it would be good to understand these with a new histogram as we have for variations.

Steve is this something you want to look at?

Comment 2 by holte@chromium.org, Mar 14 2017

Owner: holte@chromium.org
Sure, I can add this.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035ec7fb1af183cb9a902541b273208ddb6931ab

commit 035ec7fb1af183cb9a902541b273208ddb6931ab
Author: holte <holte@chromium.org>
Date: Tue Apr 04 20:16:59 2017

Track network stack error codes from UMA and UKM

BUG= 695538 

Review-Url: https://codereview.chromium.org/2774503002
Cr-Commit-Position: refs/heads/master@{#461811}

[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/android_webview/native/aw_metrics_log_uploader.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/android_webview/native/aw_metrics_log_uploader.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/android_webview/native/aw_metrics_service_client_impl.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/android_webview/native/aw_metrics_service_client_impl.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/chrome/browser/metrics/chrome_metrics_service_client.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/chromecast/browser/metrics/cast_metrics_service_client.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/chromecast/browser/metrics/cast_metrics_service_client.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/metrics_log_uploader.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/metrics_reporting_service.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/metrics_reporting_service.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/metrics_service_client.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/net/net_metrics_log_uploader.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/net/net_metrics_log_uploader.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/net/net_metrics_log_uploader_unittest.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/reporting_service.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/reporting_service.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/test_metrics_log_uploader.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/test_metrics_log_uploader.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/test_metrics_service_client.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/metrics/test_metrics_service_client.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/ukm/ukm_reporting_service.cc
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/components/ukm/ukm_reporting_service.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/ios/chrome/today_extension/today_metrics_logger.mm
[modify] https://crrev.com/035ec7fb1af183cb9a902541b273208ddb6931ab/tools/metrics/histograms/histograms.xml

Comment 4 by holte@chromium.org, Jul 18 2017

Status: Fixed (was: Available)

Sign in to add a comment