generate_build_files step failing on all Android builders |
|||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Compile Writing """\ ffmpeg_branding = "Chrome" goma_dir = "/b/build/slave/cache/goma_client" is_chrome_branded = true is_debug = false is_official_build = true proprietary_codecs = true strip_absolute_paths_from_debug_symbols = true symbol_level = 1 target_os = "android" use_goma = true """ to /b/build/slave/Android_Compile/build/src/out/Release/args.gn. /b/build/slave/Android_Compile/build/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //tools/grit/grit_rule.gni:360:7: Undefined identifier. configs += [ "//build/config/compiler:disable_unknown_pragma" ] ^------ See //components/policy/BUILD.gn:147:1: whence it was called. grit("grit_policy_templates") { ^------------------------------ See //BUILD.gn:290:7: which caused the file to be included. "//components/policy:policy_templates", ^-------------------------------------
,
Feb 23 2017
Builds are continuously failing adding infra-Tropper
,
Feb 23 2017
This builder builds per commit, so I'd be really surprised if f673f4c59c985aa8ddfab2b3821c42af25d915e4 did not cause this breakage. I would be fine with a revert. Also, troopers won't really be able to help with this. I'll cc dpranke@ though. It looks like we don't really have any trybots which cover the gn args which the perf builders use. I think i've seen these bots break a couple times in compile, which should be avoidable with a simple compile trybot.
,
Feb 23 2017
Alright! I reverted the CL. Revert CL here https://codereview.chromium.org/2708923007/
,
Feb 23 2017
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Builder/builds/142786 https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Builder/builds/142786
,
Feb 23 2017
The perf builders do official builds, so even doing compiles can be slow. Although, on Android, I think things aren't so bad as Linux or Windows. We have talked in the past about having a separate trybot that runs `gn gen` for a bunch of configurations to get coverage of things that we wouldn't otherwise get, though.
,
Mar 29 2017
The last 200 runs on this have been green. Is there anything else actionable on this, or should we close it?
,
May 31 2017
Obsolete? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pras...@chromium.org
, Feb 23 2017Status: Assigned (was: Untriaged)