New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695528 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 695620



Sign in to add a comment

[Findit] Flake Analyzer: Rerun stable build instead of going back

Project Member Reported by chanli@chromium.org, Feb 23 2017

Issue description

example:
https://findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb3ItbWVypgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJwY2hyb21pdW0uY2hyb21pdW1vcy9MaW51eCBDaHJvbWl1bU9TIFRlc3RzICgxKS8zNDEzNi9yZW1vdGluZ191bml0dGVzdHMvVjJWaWNuUmpMME52Ym01bFkzUnBiMjVVWlhOMExrRjFaR2x2THpBPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

When a stable run happens at the first build(implemented) or after flake region, rerun swarming tasks on this build multiple times or increase iterations to check if this build is really stable.
 

Comment 1 by chanli@chromium.org, Feb 23 2017

Status: Started (was: Assigned)

Comment 2 by st...@chromium.org, Feb 23 2017

In the example above, the suspected build cycle is with low confidence. Should we improve our algorithm for the determination of suspected build cycle as well?

It might worth a separate bug to track that improvement.

Comment 3 by chanli@chromium.org, Feb 23 2017

For this particular example, if we can confirm that build 34108 is really stable, we should get a different suspected build with different confidence. Although I agree we need to continue improving our algorithms to improve the correctness of suspected build

Comment 4 by st...@chromium.org, Feb 23 2017

OK, then let's revisit after build 34108 is verified.

Comment 5 by chanli@chromium.org, Feb 23 2017

Blocking: 695620
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aea7c3a7665ac7c0b52ced25a0d70785ccb56b88

commit aea7c3a7665ac7c0b52ced25a0d70785ccb56b88
Author: Chan <chanli@chromium.org>
Date: Thu Mar 09 23:18:53 2017

[Findit] Flake Analyzer:Rerun swarming tasks on stable build instead of going back directly.

If swarming rerun result is stable on a build, rerun the task with higher iterations
to either confirm this build is really stable to start sequential search or get flaky
result on a bigger iteration number.

After this change:
1. no need to check stable region
2. no need to check if test started to be flaky or maintain flaky region: every flaky  result can be treated equally

BUG= 695528 

Change-Id: Idbd5ee4d40967589f8bf1177e89dd9bb4db52aab
Reviewed-on: https://chromium-review.googlesource.com/447198
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/aea7c3a7665ac7c0b52ced25a0d70785ccb56b88/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/aea7c3a7665ac7c0b52ced25a0d70785ccb56b88/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/aea7c3a7665ac7c0b52ced25a0d70785ccb56b88/appengine/findit/waterfall/flake/lookback_algorithm.py
[modify] https://crrev.com/aea7c3a7665ac7c0b52ced25a0d70785ccb56b88/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py

Comment 7 by chanli@chromium.org, Mar 11 2017

Status: Verified (was: Started)

Sign in to add a comment