New issue
Advanced search Search tips

Issue 695523 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----

Blocking:
issue 699611



Sign in to add a comment

Add lsusb logs to Feedback reports

Project Member Reported by weifangsun@chromium.org, Feb 23 2017

Issue description

Add lsubs -t to the logs included in feedback reports.

This will allow us to track which USB devices are plugged in and if they're going through hubs.

https://paste.googleplex.com/5125408567590912
 
Blocking: 699611
Cc: weifangsun@chromium.org
Labels: M-60
Owner: afakhry@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31a45636e84fdf6cf56cac35ece3604baddf9174

commit 31a45636e84fdf6cf56cac35ece3604baddf9174
Author: afakhry <afakhry@chromium.org>
Date: Tue May 02 16:55:58 2017

Add list of plugged-in USB devices to feedback reports

This will allow us to track which USB devices are plugged in
and if they're going through hubs.

BUG= 695523 
TEST=Sys info in feedback reports should have an entry "usb_devices:

Review-Url: https://codereview.chromium.org/2856813002
Cr-Commit-Position: refs/heads/master@{#468683}

[modify] https://crrev.com/31a45636e84fdf6cf56cac35ece3604baddf9174/chrome/browser/chromeos/system_logs/command_line_log_source.cc

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
I'll revert the CL in #3, and instead modify the entry in log_tool.cc on debugd.
Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c0e7cb46c3102fb4845db60de085daf74c10f8

commit d4c0e7cb46c3102fb4845db60de085daf74c10f8
Author: afakhry <afakhry@chromium.org>
Date: Wed May 03 18:48:23 2017

Revert of Add list of plugged-in USB devices to feedback reports (patchset #1 id:1 of https://codereview.chromium.org/2856813002/ )

Reason for revert:
It's better to modify the entry in log_tool.cc on debugd.

Original issue's description:
> Add list of plugged-in USB devices to feedback reports
>
> This will allow us to track which USB devices are plugged in
> and if they're going through hubs.
>
> BUG= 695523 
> TEST=Sys info in feedback reports should have an entry "usb_devices:
>
> Review-Url: https://codereview.chromium.org/2856813002
> Cr-Commit-Position: refs/heads/master@{#468683}
> Committed: https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3604baddf9174

TBR=xiyuan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 695523 

Review-Url: https://codereview.chromium.org/2856083003
Cr-Commit-Position: refs/heads/master@{#469052}

[modify] https://crrev.com/d4c0e7cb46c3102fb4845db60de085daf74c10f8/chrome/browser/chromeos/system_logs/command_line_log_source.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b7d12cd87f02305a809f35bc5ca83fc03e0cb96c

commit b7d12cd87f02305a809f35bc5ca83fc03e0cb96c
Author: Ahmed Fakhry <afakhry@google.com>
Date: Mon May 08 19:41:03 2017

debugd: Add Atrus logs to feedback reports

Add the Atrus logs from /var/log/atrus.log to feedback reports (if
they are present).
Modify lsusb to lsusb -t to show the USB device hierarchy as we need
to know if atrus devices are connected through hubs.

BUG=chromium:699611,  chromium:695523 
TEST=There should be an entry atrus_logs in feedback sys_info.
TEST=lsusb entry in feedback sys_info should be formatted as a tree.

Change-Id: Iaf118040a45f05d68ea8ab965c54ce7e0d02a852
Reviewed-on: https://chromium-review.googlesource.com/493843
Commit-Ready: Ahmed Fakhry <afakhry@chromium.org>
Tested-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/b7d12cd87f02305a809f35bc5ca83fc03e0cb96c/debugd/src/log_tool.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in Chrome OS 9534.0.0, 60.0.3092.0.

Sign in to add a comment