Issue metadata
Sign in to add a comment
|
7% regression in tracing_perftests at 451527:451528 |
||||||||||||||||||||
Issue descriptionThere are only two CLs in this range: a test autorebaseline and https://codereview.chromium.org/2699833006 siggi: hmm honestly I have no idea how to explain this and still confused. This CL happened after you enabled it only for the cmdline switch right? So shouldn't have any effect. kraynov@ can you check if this repros locally or is just some unrelated infrastrcture fluke (would be quite suspicious)
,
Feb 23 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8986846520998169520
,
Feb 23 2017
=== BISECT JOB RESULTS === NO Perf regression found, tests failed to produce values Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : tracing_perftests Metric : TraceEventPerfTest.Submit_10000_TRACE_EVENT_with_TracedValue/events_with_value To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=events.with.value tracing_perftests Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8986846520998169520 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6431681591902208 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 23 2017
,
Feb 23 2017
My change enables some extra code in TaskStopwatch, even when the profiler is off. There's an extra bool that's set at construction <https://cs.chromium.org/chromium/src/base/tracked_objects.cc?l=935>, which is then tested twice (in Start/Stop). There's also an additional ThreadHeapUsageTracker constructed, but that's just a nullptr assignment. If this test is effectively testing creation/destruction of TaskStopwatch, it's possible that this adds 7% to that.
,
Feb 23 2017
Thanks siggi@ Will take a look
,
Feb 23 2017
Hmm afaict this is just doing lot of TRACE_EVENT_INSTANT1 in a tight loop, nothing to do with ThreadUsageTracker, or just threads at all. Let's see what kraynov finds out.
,
Feb 27 2017
tl;dr Looks like we have regression in creation of TracedValue More details here: https://codereview.chromium.org/2711313005
,
Mar 2 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8986229476054864528
,
Mar 2 2017
There is no evidence of regression. 1. This looks quite device-specific https://chromeperf.appspot.com/report?sid=49caea6d5d399e27b61b940c93ca17fca689b129e23b3ffbf3643b04f2a235d7 2. Benchmark https://codereview.chromium.org/2711313005 seems to be within noise level and plots (see file attached) shows non-deterministinc result of comparison with and witout enable_task_profiling. 3. No code of task profiler ever called in tracing_perftests. 4. No extra allocator dispatches were registered. So I believe that test has been affected by external factor and is not related to task profiler.
,
Mar 2 2017
,
Mar 2 2017
I think we need to add ref builds testing on that benchmark. I will file a separate bug.
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982624366916778560
,
Apr 11 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : tracing_perftests Metric : TraceEventPerfTest.Submit_10000_TRACE_EVENT_with_TracedValue/events_with_value To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=events.with.value tracing_perftests Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8982624366916778560 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5287561829810176 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by primiano@chromium.org
, Feb 23 2017