What is the measure result like, can we unprefix it and remove the prefixed API?
Tests: https://jsbin.com/ciyari/edit?html,output Implemented in: Blink and WebKit, not EdgeHTML or Gecko Standards: https://drafts.csswg.org/css-animations/#interface-animationevent https://drafts.csswg.org/css-transitions/#interface-transitionevent https://compat.spec.whatwg.org/
Usage spiked in April 2016 to 0.01% of pages (https://www.chromestatus.com/metrics/feature/timeline/popularity/1191) Is there a particular reason to unprefix this one, or was this filed as part of a general cleanup?
RE #2, we are filing bugs for all non-standard API's this quarter. It seems like the usage is very high, we probably should keep it for now.
The unprefixed TransitionEvent interface already exists, WebKitTransitionEvent is just an alias of that, so changing the title to reflect that.
Issue 695506 has been merged into this issue.
Per my own advice in https://docs.google.com/document/d/1LSuLWJDP02rlC9bOlidL6DzBV5kSkV5bW5Pled8HGC8/edit?usp=sharing, because these aliases aren't in Edge, I think we should attempt removal. Note that this is about the event interfaces only, not event names, CSS properties, or anything else.
Note that the ability to Document.createEvent('WebKitAnimationEvent'|'WebKitTransitionEvent') were both removed last year: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/mMJ5vh7AVyk (https://codereview.chromium.org/2822083002) https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/WebKitAnimationEvent%7Csort:date/blink-dev/VlbJIDOIIqw/ynyPNto_BQAJ (https://codereview.chromium.org/2821863002) The actual events still exist on window (https://jsbin.com/ciyari/edit?html,output still passes on ToT). Across browsers: Chrome: test 'passes' (they exist) Safari: test 'passes' (they exist) Edge: test 'fails' (they don't exist) Firefox: test 'fails' (they don't exist) I believe the correct UseCounters for accessing the constructors (or calling them? I think its just accessing) are: https://www.chromestatus.com/metrics/feature/timeline/popularity/361 https://www.chromestatus.com/metrics/feature/timeline/popularity/707 Both are high (3%), but that may just be feature checking in some popular library.
Removal of WebKitTransitionEvent has been LGTMd: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0Szv8vDQh_c
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1a49fefb6f55a8d36dc0dea99b2735f949fb063 commit e1a49fefb6f55a8d36dc0dea99b2735f949fb063 Author: Stephen McGruer <smcgruer@chromium.org> Date: Fri Sep 14 20:04:39 2018 Remove WebKitTransitionEvent This is an obsolete prefixed alias of TransitionEvent. An intent-to-remove has been sent, and has got LGTM*3. Blink intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0Szv8vDQh_c/flTY7ZClBwAJ Bug: 695504 Change-Id: Ibf8083fabac8cab474e64bb37e99e62b39b3616d TBR=timvolodine@chromium.org Change-Id: Ibf8083fabac8cab474e64bb37e99e62b39b3616d Reviewed-on: https://chromium-review.googlesource.com/1221689 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591442} [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt [add] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/WebKit/LayoutTests/external/wpt/css/css-transitions/historical.html [delete] https://crrev.com/12d57c591f8de33c079ef94c0672e0bbb757bb7f/third_party/WebKit/LayoutTests/fast/events/constructors/webkit-transition-event-constructor-expected.txt [delete] https://crrev.com/12d57c591f8de33c079ef94c0672e0bbb757bb7f/third_party/WebKit/LayoutTests/fast/events/constructors/webkit-transition-event-constructor.html [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/WebKit/LayoutTests/fast/js/constructor-length.html [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/blink/renderer/core/events/event_interface_aliases.json5 [modify] https://crrev.com/e1a49fefb6f55a8d36dc0dea99b2735f949fb063/third_party/blink/renderer/core/frame/window.idl
Removal of WebKitAnimationEvent has been LGTM'd - https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EgMUDqySZwE
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6 commit 5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6 Author: Stephen McGruer <smcgruer@chromium.org> Date: Sat Sep 22 01:22:50 2018 Remove WebKitAnimationEvent This is an obsolete prefixed alias of AnimationEvent. An intent-to-remove has been sent, and has got LGTM*3. Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EgMUDqySZwE Bug: 695504 Change-Id: Ia86e830fe3f653aa6a7b2f983afb75fd4d088831 Reviewed-on: https://chromium-review.googlesource.com/1238497 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#593405} [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/WebKit/LayoutTests/external/wpt/css/css-animations/animationevent-interface.js [add] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/WebKit/LayoutTests/external/wpt/css/css-animations/historical.html [delete] https://crrev.com/21eea353daea69d467fbe830aa9cc7aee0fa6cf3/third_party/WebKit/LayoutTests/fast/events/constructors/webkit-animation-event-constructor-expected.txt [delete] https://crrev.com/21eea353daea69d467fbe830aa9cc7aee0fa6cf3/third_party/WebKit/LayoutTests/fast/events/constructors/webkit-animation-event-constructor.html [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/WebKit/LayoutTests/fast/js/constructor-length.html [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/blink/renderer/core/events/event_interface_aliases.json5 [modify] https://crrev.com/5314c04fb2633aac4e7fb53bf55ef10b65e2fdf6/third_party/blink/renderer/core/frame/window.idl
There is one more CL to re-add a test that got dropped, then we're done here! (Pending any compat regressions).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a85bd05427361f3df2a5ab969bbff4148071d4b1 commit a85bd05427361f3df2a5ab969bbff4148071d4b1 Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Sep 24 19:04:15 2018 Add interface tests for TransitionEvent These are modelled after the similar tests that exist for AnimationEvent in css/css-animations, except written using more modern WPT style. Bug: 695504 Change-Id: I63573cf48aba6821f5e22486ef18217d0f2828ee Reviewed-on: https://chromium-review.googlesource.com/1239457 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#593620} [add] https://crrev.com/a85bd05427361f3df2a5ab969bbff4148071d4b1/third_party/WebKit/LayoutTests/external/wpt/css/css-transitions/transitionevent-interface.html
Comment 1 by tkent@chromium.org
, Feb 24 2017