Move SpdyStream upper case ascii to HeaderCoalescer |
|||
Issue descriptionThis is to follow up on crrev.com/2710053002. SpdyStream::SaveResponseHeaders() has an upper case ascii check. It can be moved to HeaderCoalescer which does other header name/value validation. However, we might lose the helpful reset stream message "Upper case characters in header:"
,
Aug 9 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbd225775340d6f88a2080a0d1cdb7da403a0d2b commit bbd225775340d6f88a2080a0d1cdb7da403a0d2b Author: Minjeong Lee <apenr1234@gmail.com> Date: Tue Nov 28 14:37:25 2017 Moved Checking Uppercase in header from SpdyStream::SaveResponseHeaders() to HeaderCoalescer::AddHeader() Bug: 695495 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie277eaec092ee1d7541c278a7501d48902473a0d Reviewed-on: https://chromium-review.googlesource.com/775551 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519678} [modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/http/bidirectional_stream_unittest.cc [modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/bidirectional_stream_spdy_impl_unittest.cc [modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/header_coalescer.cc [modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/header_coalescer_test.cc [modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/spdy_stream.cc
,
May 7 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xunji...@chromium.org
, Feb 23 2017