New issue
Advanced search Search tips

Issue 695495 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Move SpdyStream upper case ascii to HeaderCoalescer

Project Member Reported by xunji...@chromium.org, Feb 23 2017

Issue description

This is to follow up on crrev.com/2710053002.

SpdyStream::SaveResponseHeaders() has an upper case ascii check. It can be moved to HeaderCoalescer which does other header name/value validation. However, we might lose the helpful reset stream message "Upper case characters in header:"


 
Quic has similar upper case ascii checks. We can look into whether that (SpdyUtils::CopyAndValidateHeaders() and QuicTextUtils::ContainsUpperCase()) can use the same change as Spdy.

Comment 2 by b...@chromium.org, Aug 9 2017

Labels: Hotlist-GoodFirstBug
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbd225775340d6f88a2080a0d1cdb7da403a0d2b

commit bbd225775340d6f88a2080a0d1cdb7da403a0d2b
Author: Minjeong Lee <apenr1234@gmail.com>
Date: Tue Nov 28 14:37:25 2017

Moved Checking Uppercase in header from SpdyStream::SaveResponseHeaders() to HeaderCoalescer::AddHeader()

Bug:  695495 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie277eaec092ee1d7541c278a7501d48902473a0d
Reviewed-on: https://chromium-review.googlesource.com/775551
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519678}
[modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/header_coalescer.cc
[modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/header_coalescer_test.cc
[modify] https://crrev.com/bbd225775340d6f88a2080a0d1cdb7da403a0d2b/net/spdy/chromium/spdy_stream.cc

Comment 4 by b...@chromium.org, May 7 2018

Status: Fixed (was: Available)

Sign in to add a comment