New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695486 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Buried. Ping if important.
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Migrate CSP tests to WPT.

Project Member Reported by mkwst@chromium.org, Feb 23 2017

Issue description

We've upstreamed a lot of Content Security Policy tests to WPT, but now we're in a position to actually run them, and upstream everything*. In order to avoid adding minutes of runtime to the bots, I plan to import the WPT tests, then leave them disabled while migrating over individual directories and deduping.

* Everything except the extension stuff. And probably other things that currently require internal APIs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e900589febbfc49da56f18b33750786c24ba14c

commit 7e900589febbfc49da56f18b33750786c24ba14c
Author: mkwst <mkwst@chromium.org>
Date: Fri Feb 24 09:31:19 2017

Upstream Blink's 'securitypolicyviolation' tests.

Starting on the long slog to get our CSP layout tests more completely
upstreamed. This patch leaves most upstream CSP tests disabled, as I
still need to go through them in detail, but carves out the
'securitypolicyviolation' directory, moves our local tests over, and
ports them to `testharness.js`-style.

BUG=695486

Review-Url: https://codereview.chromium.org/2711913003
Cr-Commit-Position: refs/heads/master@{#452780}

[modify] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/idl-expected.txt
[rename] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/inside-dedicated-worker.html
[rename] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/inside-service-worker.https.html
[rename] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/inside-shared-worker.html
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image-from-script.sub.html
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image.sub.html
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image-from-script.sub.html
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image.sub.html
[rename] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/support/inside-worker.sub.js
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/support/inside-worker.sub.js.headers
[modify] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/targeting.html
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/inject-image.sub.js
[add] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/resource.py
[modify] https://crrev.com/7e900589febbfc49da56f18b33750786c24ba14c/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/testharness-helper.js
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/blockeduri-eval.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/blockeduri-inline.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/securitypolicyviolation-basics.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image-from-script.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/securitypolicyviolation-block-image-from-script.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/securitypolicyviolation-block-image.html
[delete] https://crrev.com/6fee69fffaad7d1254c67d1a8e1b3daa56a0f3d3/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/securitypolicyviolation/targeting.html

Comment 2 by mkwst@chromium.org, Mar 6 2017

Components: -Blink>SecurityFeature Blink>SecurityFeature>ContentSecurityPolicy
Labels: -Type-Bug -csp Type-Task

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Components: Tests>Disabled
Labels: Test-Disabled

Comment 6 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment