New issue
Advanced search Search tips

Issue 695485 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

kitchen: make dependency on user-defined recipe engine version explicit

Project Member Reported by no...@chromium.org, Feb 23 2017

Issue description

kitchen implicitly depends on the version of recipe engine pinned by users in a user repo. Make this dep explicit

proposal:
- recipe engine: define a comparable version, e.g. number
- kitchen: define a minimum supported recipe engine version. Break the build with a clear message if user-pinned recipe engine is too old
- introduce a tsmon counter like http://shortn/_TntWHfDEZn with fields "recipe_repository", "recipe_engine_version". when we need users to bump recipe engine, we will be looking at this graph. 

Re counter: there are many instances of kitchen, so either have to
- introduce new field "bot_id". Won't work if we have builds too often.
- introduce new field "swarming_run_id" and use autogen to collapse swarming_run_id fields in a precomtutation


 

Comment 1 by no...@chromium.org, Feb 23 2017

Labels: -Pri-1 Pri-2
the metrics can be implemented as a part of  bug 695489 

Comment 2 by no...@chromium.org, Feb 23 2017

Cc: d...@chromium.org
after offline discussions, amendments to the proposal:

- do not introduce comparable version or minimum support version. In both cases builds break, but without api version they will break less cleanly
- pin kitchen in canary template, not use latest ref
- the procedure to making changes to kitchen-recipe-engine interaction is as follows:
  - make change to recipe engine and kitchen
  - test it on cr-buildbucket-dev
  - ensure recipe engines pinned by users support the new protocol by looking at graphs
  - update canary template 
  - watch for alerts on internal errors
  - update prod template

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/9cf386a519d4630021d5442e4df94a01b22326f3

commit 9cf386a519d4630021d5442e4df94a01b22326f3
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Mar 01 18:37:59 2017

Comment 4 by no...@chromium.org, Apr 5 2017

Owner: no...@chromium.org
Status: Started (was: Untriaged)
i started working on propagation of recipe result with deps to kitchen, so we can monitor recipe dep revisions

Comment 5 by no...@chromium.org, Dec 2 2017

Cc: -d...@chromium.org iannucci@chromium.org no...@chromium.org
Labels: Type-Bug
Owner: ----
Status: Available (was: Started)
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment