Issue metadata
Sign in to add a comment
|
windows 7: some windows have a black titlebar when using a basic theme
Reported by
huglovef...@gmail.com,
Feb 23 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3018.3 Safari/537.36 Steps to reproduce the problem: 1. right click the desktop and select "personalize", then select a theme under "basic and high contrast themes" (not available on windows 8 and newer) 2a. open chrome's dev tools, select "undock into new separate window" under menu > dock side 2b. or: click the first link on http://www.popuptest.com/goodpopups.html What is the expected behavior? the titlebar should be gray with the rest of the UI What went wrong? it's black Did this work before? Yes 57.0.2987.74 beta Chrome version: 58.0.3018.3 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 25.0 r0
,
Feb 27 2017
I believe this is related to the GetTopAreaHeight change here: https://codereview.chromium.org/2628043002/diff/160001/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc +pkasting, I guess we could just do this? const int kHeight = 64; if (browser_view()->IsTabStripVisible()) { return GetBoundsForTabStrip(browser_view()->tabstrip()).bottom(); } else { return frame_image.isNull() ? kHeight : frame_image.height(); }
,
Feb 27 2017
I'd really like to avoid doing that if possible... Can you first check why returning a 0 in this case causes a black frame here? Maybe the right fix isn't in GetTopAreaHeight() itself, but in more correctly handling a 0 return from it at some place in the call chain.
,
Mar 2 2017
I can't repro this on my Win 10 machine. pkasting@ is there anyone with a Win7 machine that can debug this?
,
Mar 2 2017
I have one in my office. I'm not in there until next week, so you'd be welcome to use it. Dunno if it's easy to let you log in to my machine, though?
,
Mar 8 2017
You can get that frame on Windows 10 by launching with --disable-dwm-composition, I just tested and it reproduces. I can dig into it more if you'd like.
,
Mar 8 2017
Thanks bsep@, assigning to you for now
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/683596645abbc42f0c20768c1579a578f5b36553 commit 683596645abbc42f0c20768c1579a578f5b36553 Author: bsep <bsep@chromium.org> Date: Thu Mar 09 22:31:17 2017 Fix opaque frame popup titlebar not being painted. R=pkasting@chromium.org,thomasanderson@chromium.org BUG= 695473 , 670959 Review-Url: https://codereview.chromium.org/2741603002 Cr-Commit-Position: refs/heads/master@{#455885} [modify] https://crrev.com/683596645abbc42f0c20768c1579a578f5b36553/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
,
Mar 9 2017
,
May 8 2017
Issue 718886 has been merged into this issue.
,
May 8 2017
This issue is still seen in the latest stable #58.0.3029.96. bsep@ - Could you please merge the fix to M-58. Thanks...!!
,
May 8 2017
Reopening as per c#11
,
May 8 2017
Re-closing this issue. Discussed this with govind@ offline and this bug does not warrant a merge to M58.
,
May 30 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sureshkumari@chromium.org
, Feb 27 2017Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)